-
Notifications
You must be signed in to change notification settings - Fork 270
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
core: Report names rather than ids in affinity conflicts
When an affinity conflict occurs, the hosts or VMs participating in the conflict are reported by their ids. This is accurate but not very user friendly, especially in the web UI dialog. Let’s report the conflicting entities by their names instead. We must retrieve the names from the corresponding DAOs. In theory, AffinityGroup’s should contain entity names corresponding to the ids, but this doesn’t hold and the names are often missing there. Due to the DAO access, AffinityValidator.checkAffinityGroupConflicts can no longer be static. And because AffinityValidator is a singleton, it cannot be used in tests as it is (AFAICT). That means we have to mock AffinityValidator.checkAffinityGroupConflicts in some tests and give up on testing that method there. Bug-Url: https://bugzilla.redhat.com/1991622
- Loading branch information
Showing
4 changed files
with
31 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters