core: copy disk will set the correct allocation policy for the new co…

…pied disk

while coping disk that has incremental  backup flag up and set to be preallocated
the new copied disk will change the allocation policy to thin provition.
now it will change allocation policy to be the same as it was set on the original disk

Bug-Url: https://bugzilla.redhat.com/2072423
Signed-off-by: Artiom Divak <adivak@redhat.com>

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java

@@ -156,6 +156,7 @@ private void createVolume() {
         parameters.setParentCommand(getActionType());
         parameters.setParentParameters(getParameters());
         parameters.setEndProcedure(EndProcedure.COMMAND_MANAGED);
+        parameters.setBackup(getDiskImage().getBackup());
         runInternalAction(ActionType.CreateVolumeContainer, parameters);
     }
 

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java

@@ -13,9 +13,9 @@
 import org.ovirt.engine.core.bll.context.CommandContext;
 import org.ovirt.engine.core.bll.utils.PermissionSubject;
 import org.ovirt.engine.core.common.VdcObjectType;
-import org.ovirt.engine.core.common.action.ActionType;
 import org.ovirt.engine.core.common.action.CreateVolumeContainerCommandParameters;
 import org.ovirt.engine.core.common.asynctasks.AsyncTaskType;
+import org.ovirt.engine.core.common.businessentities.storage.DiskBackup;
 import org.ovirt.engine.core.common.businessentities.storage.DiskContentType;
 import org.ovirt.engine.core.common.businessentities.storage.DiskImage;
 import org.ovirt.engine.core.common.businessentities.storage.VolumeFormat;
@@ -81,7 +81,8 @@ private CreateVolumeVDSCommandParameters getCreateVDSCommandParameters() {
     }
 
     private VolumeType getType() {
-        if (getParentParameters() != null && getParentParameters().getParentCommand() == ActionType.ConvertDisk) {
+        //When incremental flag is up there is now need to change the type of the volume
+        if (getParameters().getBackup() == DiskBackup.Incremental) {
             return getParameters().getVolumeType();
         }
 

backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateVolumeContainerCommandParameters.java

@@ -1,5 +1,6 @@
 package org.ovirt.engine.core.common.action;
 
+import org.ovirt.engine.core.common.businessentities.storage.DiskBackup;
 import org.ovirt.engine.core.common.businessentities.storage.VolumeFormat;
 import org.ovirt.engine.core.common.businessentities.storage.VolumeType;
 import org.ovirt.engine.core.compat.Guid;
@@ -13,6 +14,8 @@ public class CreateVolumeContainerCommandParameters extends StorageJobCommandPar
     private Long initialSize;
     private boolean legal = true;
 
+    private DiskBackup backup;
+
     private Integer sequenceNumber;
 
     public CreateVolumeContainerCommandParameters() {
@@ -100,4 +103,13 @@ public Integer getSequenceNumber() {
     public void setSequenceNumber(Integer sequenceNumber) {
         this.sequenceNumber = sequenceNumber;
     }
+
+    public DiskBackup getBackup() {
+        return backup;
+    }
+
+    public void setBackup(DiskBackup backup) {
+        this.backup = backup;
+    }
+
 }