cleanup in MoveOrCopyDiskCommand

Signed-off-by: Arik Hadas <ahadas@redhat.com>
oVirt · Aug 2, 2022 · 5efd903 · 5efd903
1 parent e7b673a
commit 5efd903
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java b/...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
@@ -65,7 +65,6 @@
 import org.ovirt.engine.core.dao.DiskImageDao;
 import org.ovirt.engine.core.dao.DiskVmElementDao;
 import org.ovirt.engine.core.dao.ImageStorageDomainMapDao;
-import org.ovirt.engine.core.dao.SnapshotDao;
 import org.ovirt.engine.core.dao.StorageDomainDao;
 import org.ovirt.engine.core.dao.UnregisteredDisksDao;
 import org.ovirt.engine.core.dao.VmDao;
@@ -101,8 +100,6 @@ public class MoveOrCopyDiskCommand<T extends MoveOrCopyImageGroupParameters> ext
     @Inject
     private VmDao vmDao;
     @Inject
-    private SnapshotDao snapshotDao;
-    @Inject
     @Typed(ConcurrentChildCommandsExecutionCallback.class)
     private Instance<ConcurrentChildCommandsExecutionCallback> callbackProvider;
 
@@ -174,10 +171,10 @@ && checkIfNeedToBeOverride()
                 && setAndValidateDiskProfiles()
                 && setAndValidateQuota()
                 && validatePassDiscardSupportedForDestinationStorageDomain()
-                && isCopyWithLocalDc();
+                && noCopyBetweenLocalAndManagedBlockStorages();
     }
 
-    protected boolean isCopyWithLocalDc() {
+    protected boolean noCopyBetweenLocalAndManagedBlockStorages() {
         Guid sourceDomainId = getParameters().getSourceDomainId();
         StorageDomain sourceStorageDomain = storageDomainDao.getForStoragePool(sourceDomainId, getImage().getStoragePoolId());