frontend: introduce isolate threads

This patch adds the isolate threads option to the UI. Change-Id: I7b7c095b2acad2f0693f238a2dd3b4c86f9fb63b Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
oVirt · Apr 12, 2022 · 93dac04 · 93dac04
1 parent 0b80e60
commit 93dac04
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 1 deletion.
diff --git a/...mmonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CpuPinningListModel.java b/...mmonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CpuPinningListModel.java
@@ -36,6 +36,10 @@ public CpuPinningListModel() {
                 CpuPinningPolicy.DEDICATED,
                 constants.cpuPinningDedicatedDescription(),
                 constants.cpuPinningDedicatedDisabled()));
+        items.add(new CpuPinningListModelItem(
+                CpuPinningPolicy.ISOLATE_THREADS,
+                constants.cpuPinningIsolateThreadsDescription(),
+                constants.cpuPinningDedicatedDisabled()));
 
         setItems(items);
         setSelectedCpuPolicy(CpuPinningPolicy.NONE);

diff --git a/...les/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java b/...les/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
@@ -4080,6 +4080,7 @@ protected void updateCpuPinningPolicy() {
 
         cpuPinningPolicy.setCpuPolicyEnabled(CpuPinningPolicy.MANUAL, defaultHostSelected);
         cpuPinningPolicy.setCpuPolicyEnabled(CpuPinningPolicy.DEDICATED, isDedicatedCpusSupported && numaNodesUnpinned);
+        cpuPinningPolicy.setCpuPolicyEnabled(CpuPinningPolicy.ISOLATE_THREADS, isDedicatedCpusSupported && numaNodesUnpinned);
     }
 
     protected void cpuPinningPolicyChanged() {

diff --git a/.../webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java b/.../webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
@@ -1269,6 +1269,8 @@ public interface LocalizedEnums extends ConstantsWithLookup {
 
     String CpuPinningPolicy___DEDICATED();
 
+    String CpuPinningPolicy___ISOLATE_THREADS();
+
     String SerialNumberPolicy___HOST_ID();
 
     String SerialNumberPolicy___VM_ID();

diff --git a/...end/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java b/...end/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
@@ -2233,6 +2233,8 @@ public interface UIConstants extends Constants {
 
     String cpuPinningDedicatedDescription();
 
+    String cpuPinningIsolateThreadsDescription();
+
     String cpuPinningDedicatedDisabled();
 
     String accountSettings();

diff --git a/...odules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties b/...odules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
@@ -496,6 +496,7 @@ CpuPinningPolicy___NONE=None
 CpuPinningPolicy___MANUAL=Manual
 CpuPinningPolicy___RESIZE_AND_PIN_NUMA=Resize and Pin NUMA
 CpuPinningPolicy___DEDICATED=Dedicated
+CpuPinningPolicy___ISOLATE_THREADS=Isolate threads
 DiskInterface___IDE=IDE
 DiskInterface___SCSI=SCSI
 DiskInterface___SPAPR_VSCSI=sPAPR VSCSI

diff --git a/...n/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties b/...n/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
@@ -1133,5 +1133,6 @@ directPermissions=Direct
 customParallelMigrationsDisabledReason=Available only when Custom Parallel Migrations are selected.
 clusterDefaultCustomParallelMigrationsDisabledReason=Cannot change for Cluster default value.
 cpuPinningDedicatedDescription=Exclusively pin virtual CPUs to host physical CPUs. If a VM has NUMA enabled, the NUMA nodes will be pinned automatically.
-cpuPinningDedicatedDisabled=Dedicated CPU Policy is available on cluster version 4.7 or newer. If the VM has NUMA enabled, all nodes have to be unpinned.
+cpuPinningDedicatedDisabled=The CPU Policy is available on cluster version 4.7 or newer. If the VM has NUMA enabled, all nodes have to be unpinned.
+cpuPinningIsolateThreadsDescription=Exclusively pin virtual CPUs to host physical CPUs. Each virtual CPU gets a physical core. If a VM has NUMA enabled, the NUMA nodes will be pinned automatically.
 statelessVmFieldDisabledReason=Disabled when using the latest version of a template is selected.