Skip to content

Commit

Permalink
core: Comment about VM affinity validation on migration
Browse files Browse the repository at this point in the history
Added a comment to MaintenanceNumberOfVdssCommand to avoid confusion
about VM affinity types checked in validation and execution phases of
the command.

Change-Id: I583f720ce1f82ca4f23541b987665cce4f0a11d9
Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
  • Loading branch information
smelamud authored and ahadas committed Jul 18, 2022
1 parent d4dbacf commit be12b13
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,8 @@ private boolean handlePositiveEnforcingAffinityGroup(Guid vdsId, List<VM> runnin
return true;
}

// Only VM-to-VM hard affinity is checked here. Other affinity types, including VM-to-host hard affinity are
// probed by SchedulingManager.canSchedule() call in execution phase of the command.
List<AffinityGroup> affinityGroups =
affinityGroupDao.getPositiveEnforcingAffinityGroupsByRunningVmsOnVdsId(vdsId);
if (!affinityGroups.isEmpty()) {
Expand Down

0 comments on commit be12b13

Please sign in to comment.