packaging: Add KeycloakEnv.SUPPORTED

Allow setup code to decide/know if Keycloak integration is supported. Set as unsupported for RHV. Change-Id: I5ec0fee15cc761238989afaec55db9a5aa831778 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
oVirt · Jun 7, 2022 · c20976c · c20976c
1 parent 3570a48
commit c20976c
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/ovirt-engine.spec.in b/ovirt-engine.spec.in
@@ -1020,6 +1020,14 @@ OVESETUP_CONFIG/jbossHome=str:/opt/rh/eap7/root/usr/share/wildfly
 OVESETUP_CONFIG/pkiRenewalDocUrl=str:https://access.redhat.com/solutions/1572983
 __EOF__
 
+# Disable automatic keycloak integration in RHV.
+# Manual integration is possible and documented at ???
+# TODO: Provide a link. I found this, but think there are probably better ones:
+# https://www.redhat.com/en/blog/red-hat-it-single-sign-onsso-runs-red-hat-virtualization
+cat >> "%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf" << __EOF__
+OVESETUP_CONFIG/keycloakSupported=bool:False
+__EOF__
+
 cat > "%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging-wsp.conf" << __EOF__
 [environment:default]
 __EOF__

diff --git a/packaging/setup/ovirt_engine_setup/engine_common/constants.py b/packaging/setup/ovirt_engine_setup/engine_common/constants.py
@@ -405,6 +405,8 @@ class KeycloakEnv(object):
     def ENABLE(self):
         return 'OVESETUP_CONFIG/keycloakEnable'
 
+    SUPPORTED = 'OVESETUP_CONFIG/keycloakSupported'
+
     @osetupattrs(
         is_secret=True,
         answerfile=True,

diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py
@@ -53,6 +53,15 @@ def _generatePassword():
     def __init__(self, context):
         super(Plugin, self).__init__(context=context)
 
+    @plugin.event(
+        stage=plugin.Stages.STAGE_BOOT,
+    )
+    def _boot(self):
+        self.environment.setdefault(
+            oengcommcons.KeycloakEnv.SUPPORTED,
+            False
+        )
+
     @plugin.event(
         stage=plugin.Stages.STAGE_INIT,
     )
@@ -86,6 +95,15 @@ def _init(self):
             False
         )
 
+    @plugin.event(
+        stage=plugin.Stages.STAGE_SETUP,
+        condition=lambda self: not self.environment[
+            oengcommcons.KeycloakEnv.SUPPORTED
+        ],
+    )
+    def _setup(self):
+        self.environment[oengcommcons.KeycloakEnv.ENABLE] = False
+
     @plugin.event(
         stage=plugin.Stages.STAGE_CUSTOMIZATION,
         name=oengcommcons.Stages.ADMIN_PASSWORD_SET,