core: fix transferClientType deserialization

The existence of the unusef toString method breaks jackson deseralization for the transferClientType parameter. Since this parameter should always be set and toString is not used, this patch simply removes this method. Bug-Url: https://bugzilla.redhat.com/2123008 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
oVirt · Sep 6, 2022 · c97ecc6 · c97ecc6
1 parent 27dc8ee
commit c97ecc6
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/...c/main/java/org/ovirt/engine/core/common/businessentities/storage/TransferClientType.java b/...c/main/java/org/ovirt/engine/core/common/businessentities/storage/TransferClientType.java
@@ -35,7 +35,6 @@ public static TransferClientType forValue(int value) {
     public String toString() {
         return description;
     }
-
     public boolean isBrowserTransfer() {
         return this == TRANSFER_VIA_BROWSER;
     }

diff --git a/.../src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java b/.../src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
@@ -1,7 +1,6 @@
 package org.ovirt.engine.core.utils.serialization.json;
 
 import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES;
-import static com.fasterxml.jackson.databind.DeserializationFeature.READ_ENUMS_USING_TO_STRING;
 import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
 
 import java.io.IOException;
@@ -56,7 +55,6 @@ public class JsonObjectDeserializer implements Deserializer {
         formattedMapper.addMixIn(EngineFault.class, JsonEngineFaultMixIn.class);
         formattedMapper.configure(FAIL_ON_UNKNOWN_PROPERTIES, false);
         formattedMapper.configure(READ_UNKNOWN_ENUM_VALUES_AS_NULL, true);
-        formattedMapper.configure(READ_ENUMS_USING_TO_STRING, true);
 
         formattedMapper.activateDefaultTyping(LaissezFaireSubTypeValidator.instance);
     }