-
Notifications
You must be signed in to change notification settings - Fork 263
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
packaging: setup: Filter from logs secrets from otopi answer files
When running engine-setup with an answer file generated by a previous interactive engine-setup, without this patch, we log some secrets unfiltered. Fix this: - Require a new otopi that provides LOG_FILTER_QUESTIONS. - Conflict with older dwh/keycloak that are incompatible with the changes in getCredentials (see below). - Add an attribute 'asked_on' for constants. If a constant is_secret, require setting asked_on, to a list of question names that might change/set it. - Add a field CREDS_Q_NAME_FUNC to the various *DB_ENV_KEYS. This field should point at a function that should return the question name for a particular field. - Change getCredentials to not get a parameter queryprefix for constructing the question names, instead relying on CREDS_Q_NAME_FUNC. - Add functions *question_name for both passing as CREDS_Q_NAME_FUNC and for asked_on. - And finally: Patch filter_secrets.py to also loop over all the constants that set is_secret, and add their asked_on to env[LOG_FILTER_QUESTIONS]. This makes otopi filter out all the answers provided for these questions in answer files. Change-Id: Ibaca2a03f2020750f96ae30a3448ea2ad17fe43c Signed-off-by: Yedidyah Bar David <didi@redhat.com>
- Loading branch information
Showing
11 changed files
with
86 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters