core: update actual size after conversion

The actual size of a volume is reduced when converting the disk from
COW/preallocated to COW/thin on a block storage domain is not updated,
making it seem like disk consumes more than it actually does.

This patch updates the actual size after conversion.

Bug-Url: https://bugzilla.redhat.com/2086561
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ConvertDiskCommand.java

@@ -36,6 +36,7 @@
 import org.ovirt.engine.core.common.businessentities.VM;
 import org.ovirt.engine.core.common.businessentities.VdsmImageLocationInfo;
 import org.ovirt.engine.core.common.businessentities.storage.DiskImage;
+import org.ovirt.engine.core.common.businessentities.storage.DiskImageDynamic;
 import org.ovirt.engine.core.common.businessentities.storage.ImageStatus;
 import org.ovirt.engine.core.common.businessentities.storage.VolumeFormat;
 import org.ovirt.engine.core.common.businessentities.storage.VolumeType;
@@ -46,6 +47,7 @@
 import org.ovirt.engine.core.compat.Guid;
 import org.ovirt.engine.core.dao.BaseDiskDao;
 import org.ovirt.engine.core.dao.DiskImageDao;
+import org.ovirt.engine.core.dao.DiskImageDynamicDao;
 import org.ovirt.engine.core.dao.ImageDao;
 import org.ovirt.engine.core.dao.StorageDomainDao;
 import org.ovirt.engine.core.dao.VmDao;
@@ -57,6 +59,9 @@ public class ConvertDiskCommand<T extends ConvertDiskCommandParameters> extends
     @Inject
     private DiskImageDao diskImageDao;
 
+    @Inject
+    private DiskImageDynamicDao diskImageDynamicDao;
+
     @Inject
     private ImageDao imageDao;
 
@@ -298,6 +303,9 @@ private boolean switchImage() {
         DiskImage newImage = DiskImage.copyOf(getDiskImage());
         newImage.setImageId(getParameters().getNewVolGuid());
         newImage.setSize(info.getSize());
+        DiskImageDynamic diskImageDynamic = new DiskImageDynamic();
+        diskImageDynamic.setId(newImage.getImageId());
+        diskImageDynamic.setActualSize(info.getActualSizeInBytes());
         if (getParameters().getVolumeFormat() != null) {
             if (info.getVolumeFormat() != getParameters().getVolumeFormat()) {
                 log.error("Requested format '{}' doesn't match format on storage '{}'",
@@ -323,6 +331,7 @@ private boolean switchImage() {
         TransactionSupport.executeInNewTransaction(() -> {
             addDiskImageToDb(newImage, getCompensationContext(), true);
             imageDao.update(getDiskImage().getImage());
+            diskImageDynamicDao.update(diskImageDynamic);
 
             return null;
         });