Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5.3.2] Host kernel command line incorrectly quoted in oVirt 4.5.3.2 #775

Closed
amato-gianluca opened this issue Dec 8, 2022 · 0 comments · Fixed by #904
Closed

[4.5.3.2] Host kernel command line incorrectly quoted in oVirt 4.5.3.2 #775

amato-gianluca opened this issue Dec 8, 2022 · 0 comments · Fixed by #904

Comments

@amato-gianluca
Copy link

Hello.

I recently changed the kernel command line of one of my hosts using oVirt Manager (a custom kernel command line, not one obtained by choose a list of standard features). This did not work as expected. The kernel options I specify are added to the real kernel command line as an unique single-quoted string, therefore the kernel does not recognize them.

For example, this is the file /boot/loader/entries/ovirt-node-ng-4.5.3.2-0.20221028.0+1-4.18.0-408.el8.x86_64.conf which I get in one of my hosts:

title ovirt-node-ng-4.5.3.2-0.20221028.0 (4.18.0-408.el8.x86_64)
version 4.18.0-408.el8.x86_64
linux //ovirt-node-ng-4.5.3.2-0.20221028.0+1/vmlinuz-4.18.0-408.el8.x86_64
initrd //ovirt-node-ng-4.5.3.2-0.20221028.0+1/initramfs-4.18.0-408.el8.x86_64.img
options crashkernel=auto resume=/dev/mapper/onn_ovirt--clai1-swap
rd.lvm.lv=onn_ovirt-clai1/ovirt-node-ng-4.5.3.2-0.20221028.0+1
rd.lvm.lv=onn_ovirt-clai1/swap rhgb quiet intel_iommu=on
root=/dev/onn_ovirt-clai1/ovirt-node-ng-4.5.3.2-0.20221028.0+1
boot=UUID=9d44cf2a-38bb-477d-b542-4bfc30463d1f rootflags=discard
img.bootid=ovirt-node-ng-4.5.3.2-0.20221028.0+1 'modprobe.blacklist=nouveau
transparent_hugepage=never hugepagesz=1G hugepages=256 default_hugepagesz=1G'
id centos-0-4.18.0-408.el8.x86_64
grub_users $grub_users
grub_arg --unrestricted
grub_class kernel

You can see that the last part of the options is surrounded by quotes. I can later fix the problem by manually changing the files in /boot/loader/entries/, but this makes the GUI option useless.

@sandrobonazzola sandrobonazzola changed the title Host kernel command line incorrectly quoted in oVirt 4.5.3.2 [4.5.3.2] Host kernel command line incorrectly quoted in oVirt 4.5.3.2 Feb 10, 2023
mmartinv added a commit to mmartinv/ovirt-engine that referenced this issue Dec 13, 2023
Remove unneeded quotes when running grubby to update
kernel cmdline.

Fixes: oVirt#775

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
michalskrivanek pushed a commit that referenced this issue Jan 2, 2024
Remove unneeded quotes when running grubby to update
kernel cmdline.

Fixes: #775

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants