Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental backup is not preserved when creating a template from a VM #779

Closed
ahadas opened this issue Dec 15, 2022 · 0 comments
Closed

Incremental backup is not preserved when creating a template from a VM #779

ahadas opened this issue Dec 15, 2022 · 0 comments
Labels
storage

Comments

@ahadas
Copy link
Member

ahadas commented Dec 15, 2022

When creating a template from a virtual machine, the 'incremental backup' setting doesn't propagate from the disks of the virtual machine to those of the template
@ahadas ahadas changed the title 'incremental backup' is not preserved when creating a template from a vm Incremental backup is not preserved when creating a template from a VM Dec 15, 2022
@ahadas ahadas added the storage label Dec 15, 2022
ahadas added a commit to ahadas/ovirt-engine that referenced this issue Dec 15, 2022
@ahadas
fix oVirt#779: propagate backup mode to template disks
00b99c9 
Previously, all template disks were created with backup mode = NONE
regardless of the backup mode of the disks of the VM that the template
is created from.

Now the backup mode would propagte from the VM disks to the template
disks when their format is qcow2. If the template disks are created
as raw their backup mode would be NONE. Enabing to create template
disks with incremental backup enabled from VM disks that are raw is
outside of the scope of this change.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas added a commit to ahadas/ovirt-engine that referenced this issue Dec 15, 2022
@ahadas
fix oVirt#779: propagate backup mode to template disks
ef954c5 
Previously, all template disks were created with backup mode = NONE
regardless of the backup mode of the disks of the VM that the template
is created from.

Now the backup mode would propagate from the VM disks to the template
disks when their format is qcow2. If the template disks are created
as raw their backup mode would be NONE. Enabing to create template
disks with incremental backup enabled from VM disks that are raw is
outside of the scope of this change.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas added a commit to ahadas/ovirt-engine that referenced this issue Dec 15, 2022
@ahadas
fix oVirt#779: propagate backup mode to template disks
ced342b 
Previously, all template disks were created with backup mode = NONE
regardless of the backup mode of the disks of the VM that the template
is created from.

Now the backup mode would propagate from the VM disks to the template
disks when their format is qcow2. If the template disks are created
as raw their backup mode would be NONE. Enabing to create template
disks with incremental backup enabled from VM disks that are raw is
outside of the scope of this change.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas added a commit to ahadas/ovirt-engine that referenced this issue Dec 15, 2022
@ahadas
fix oVirt#779: propagate backup mode to template disks
4c0279d 
Previously, all template disks were created with backup mode = NONE
regardless of the backup mode of the disks of the VM that the template
is created from.

Now the backup mode would propagate from the VM disks to the template
disks when their format is qcow2. If the template disks are created
as raw their backup mode would be NONE. Enabing to create template
disks with incremental backup enabled from VM disks that are raw is
outside of the scope of this change.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas added a commit to ahadas/ovirt-engine that referenced this issue Dec 15, 2022
@ahadas
fix oVirt#779: propagate backup mode to template disks
aa2c285 
Previously, all template disks were created with backup mode = NONE
regardless of the backup mode of the disks of the VM that the template
is created from.

Now the backup mode would propagate from the VM disks to the template
disks when their format is qcow2. If the template disks are created
as raw their backup mode would be NONE. Enabing to create template
disks with incremental backup enabled from VM disks that are raw is
outside of the scope of this change.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
@ahadas ahadas closed this as completed in e7af087 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahadas