engine: Check concrete disk permissions firstly on TransferImageStatus #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dupondje @BrooklynDewolf can you please review? |
|
Code looks good to me. Nice cleanup :) |
|
/OST |
sandrobonazzola
force-pushed
the
bugfix/check-concrete-disk-perms-on-status-command
branch
from
19f6162
to
49f91aa
Compare
|
/ost |
sandrobonazzola
approved these changes
Jun 3, 2024
|
/ost |
sandrobonazzola
force-pushed
the
bugfix/check-concrete-disk-perms-on-status-command
branch
from
49f91aa
to
fa6fea1
Compare
|
/ost |
|
OST is failing Not sure how much this failure is related to this PR. |
|
@sandrobonazzola This was an issue related to an earlier commit that has been merged into the master branch. It has been fixed in #948 |
sandrobonazzola
force-pushed
the
bugfix/check-concrete-disk-perms-on-status-command
branch
from
fa6fea1
to
5fcc46f
Compare
…sCommand There is some situations when storageDomainId is not come with parameters (image upload cancel and pause operations). For this operations checked CREATE_DISK permission on SYSTEM_OBJECT (i.e. system-wide). Problem starts when we give permissions for user only on concrete storage domain object (not system-wide). Then permission check failed for operations without storage domain id info in parameters. Here I just add check permission for disk before other objects. Signed-off-by: Stanislav Melnichuk <melnichuk.stas@gmail.com>
sandrobonazzola
force-pushed
the
bugfix/check-concrete-disk-perms-on-status-command
branch
from
5fcc46f
to
28e8695
Compare
|
/ost |
sandrobonazzola
approved these changes
Jun 10, 2024
|
/ost |
|
OST passed on run 113878 , merging based on previous reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some situations when storageDomainId is not come with parameters (image upload cancel and pause operations) for TransferImageStatusCommand. For this operations checked CREATE_DISK permission on SYSTEM_OBJECT (i.e. system-wide). Problem starts when we give permissions for user only on concrete storage domain object (not system-wide). Then permission check failed for operations without storage domain id info in parameters. Here I just add check permission for disk before other objects.
Are you the owner of the code you are sending in, or do you have permission of the owner?
y