-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: Check concrete disk permissions firstly on TransferImageStatus #946
engine: Check concrete disk permissions firstly on TransferImageStatus #946
Conversation
@dupondje @BrooklynDewolf can you please review? |
Code looks good to me. Nice cleanup :) |
/OST |
19f6162
to
49f91aa
Compare
/ost |
/ost |
49f91aa
to
fa6fea1
Compare
/ost |
OST is failing
Not sure how much this failure is related to this PR. |
@sandrobonazzola This was an issue related to an earlier commit that has been merged into the master branch. It has been fixed in #948 |
fa6fea1
to
5fcc46f
Compare
…sCommand There is some situations when storageDomainId is not come with parameters (image upload cancel and pause operations). For this operations checked CREATE_DISK permission on SYSTEM_OBJECT (i.e. system-wide). Problem starts when we give permissions for user only on concrete storage domain object (not system-wide). Then permission check failed for operations without storage domain id info in parameters. Here I just add check permission for disk before other objects. Signed-off-by: Stanislav Melnichuk <melnichuk.stas@gmail.com>
5fcc46f
to
28e8695
Compare
/ost |
/ost |
OST passed on run 113878 , merging based on previous reviews. |
There is some situations when storageDomainId is not come with parameters (image upload cancel and pause operations) for TransferImageStatusCommand. For this operations checked CREATE_DISK permission on SYSTEM_OBJECT (i.e. system-wide). Problem starts when we give permissions for user only on concrete storage domain object (not system-wide). Then permission check failed for operations without storage domain id info in parameters. Here I just add check permission for disk before other objects.
Are you the owner of the code you are sending in, or do you have permission of the owner?
y