core: use manged_path for running VMs with MBS devices #104

bennyz · 2022-02-28T12:27:15Z

No description provided.

muliby-lb · 2022-04-19T15:51:32Z

I'm happy to confirm that the latest drop passed a sniff test with Lightbits LightOS! One VM one volume, so not exactly comprehensive testing yet, but a great step forward!
image

muliby-lb · 2022-05-02T07:19:24Z

Hi @bennyz, any updates on when this one will be merged or what else is needed before it can be merged?

Send the storage domain id to vdsm when attaching an MBS volume. This will be useful in case we need to distinguish between two volumes with the same id (live storage migration for example). Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

Since multiple volumes with the same id can be attached to the same host (live storage migration for example), we now send the sd_id as well to be able to distinguish between them. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

When copying from a traditional domain to an MBS domain we create a new ManagedBlockStorageDisk that is based on the source disk with updated paramteters. Currently createManagedBlockDiskFromDiskImage adds the target Storage Domain to the target's disk list, however, this list already contains the source domain, which makes the disk present on two Storage Domains. This patch overrides the original disks Storage Domain list.

bennyz · 2022-05-26T08:07:51Z

/ost

nirs

If it is possible, I would split to 2 prs:

Use managed_path
Specify sd_id

The first should be enough to test this feature. The second is need to so someone can add LSM in the future.

nirs · 2022-05-26T17:14:43Z

...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java

+                path = (String) managedBlockStorageDisk.getDevice().get(DeviceInfoReturn.MANAGED_PATH);
+            } else {
+                path = (String) managedBlockStorageDisk.getDevice().get(DeviceInfoReturn.PATH);
+            }


How does this work for running vm when we upgrade the cluster version while the vm is running?

The vm will start using "path". After the upgrade, if we migrate the vm, we will use "managed_path", and the migration will likely fail.

Can we always use "managed_path"?

what about older cluster levels, if we do live migration in a 4.6 cluster for example?

Migration to/from 4.6 cluster will not work with managed_path. But since this is tech preview we don't need to care about it.

If we want to avoid this issue we can use managed_path only for lightos, and continue to use path for rbd and mpath. But this means we carry to ways to work with mbs storage, which is bad. I this to break this now and not later.

Now it is clear, we use manage_path for cluster level 4.7, and path for older cluster levels since vdsm in older versions did not support managed_path.

nirs · 2022-05-26T17:16:22Z

...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java

-                // For rbd we need to pass the entire path since we rely on more than a single
-                // variable e.g: /dev/rbd/<pool-name>/<vol-name>
-                metadata = Collections.singletonMap("RBD", path);
+                metadata.put("RBD", path);


So before we started with empty map, and then replaced it with Collections.singletonMap?
Using metadata looks good, but is this change needed to support managed_path or a cleanup that we can do later?

unfortunately it is not a cleanup, singletonMap was incorrect because it's immutable which would prevent setting metadata.put("managed", "true"); later on

nirs · 2022-05-26T17:17:23Z

...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java

-                        "GUID", (String)attachment.get(DeviceInfoReturn.SCSI_WWN),
-                        "managed", "true"
-                );
+                metadata.put("GUID", (String)attachment.get(DeviceInfoReturn.SCSI_WWN));


This is also nicer, but is this require to get this change merged?

nirs · 2022-05-26T17:17:52Z

...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java

            }

+            metadata.put("managed", "true");


Isn't this the only required change?

nirs · 2022-05-26T17:21:41Z

...java/org/ovirt/engine/core/bll/storage/disk/managedblock/ManagedBlockStorageCommandUtil.java

@@ -142,7 +142,9 @@ public VDSReturnValue attachManagedBlockStorageDisk(ManagedBlockStorageDisk disk



Change makes sense - but is required only to allow LSM which is not supported yet.
Can we defer this change so we can merge sooner the lightos support?

Until we do this change, all disks will use blank uuid. Adding the sd id is likely
wanted also in 4.5.1, but we can add it after the basics are merged, no?

the vdsm PR included these changes so I tested them all together, I can separate it now since it's merged in vdsm

nirs · 2022-05-26T17:22:44Z

...rt/engine/core/bll/storage/disk/managedblock/DisconnectManagedBlockStorageDeviceCommand.java

@@ -76,6 +76,7 @@ private VDSReturnValue detachVolume() {
        AttachManagedBlockStorageVolumeVDSCommandParameters params =


This is similar to the previous commit adding sd_id, no?

nirs · 2022-06-01T20:24:10Z

...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java

+                path = (String) managedBlockStorageDisk.getDevice().get(DeviceInfoReturn.MANAGED_PATH);
+            } else {
+                path = (String) managedBlockStorageDisk.getDevice().get(DeviceInfoReturn.PATH);
+            }


Now it is clear, we use manage_path for cluster level 4.7, and path for older cluster levels since vdsm in older versions did not support managed_path.

bennyz force-pushed the mbs-run-path branch 4 times, most recently from 892cc70 to 26a901e Compare March 9, 2022 08:49

bennyz added storage on hold labels Mar 9, 2022

bennyz force-pushed the mbs-run-path branch from 26a901e to 55167e4 Compare March 27, 2022 13:06

bennyz force-pushed the mbs-run-path branch from 55167e4 to ebaf98e Compare April 19, 2022 12:57

bennyz changed the title ~~WIP core: use run_path for running VMs with MBS devices~~ WIP core: use maanged_path for running VMs with MBS devices Apr 20, 2022

bennyz changed the title ~~WIP core: use maanged_path for running VMs with MBS devices~~ WIP core: use manged_path for running VMs with MBS devices Apr 20, 2022

bennyz force-pushed the mbs-run-path branch 2 times, most recently from 3e592fb to 837e8ce Compare May 9, 2022 13:43

bennyz added 3 commits May 18, 2022 14:34

core: use managed_path for running VMs with MBS devices

9b7a408

core: add sd_id to detachManagedBlockVolume

052477c

Since multiple volumes with the same id can be attached to the same host (live storage migration for example), we now send the sd_id as well to be able to distinguish between them. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

bennyz force-pushed the mbs-run-path branch from 837e8ce to c1d673e Compare May 19, 2022 12:22

bennyz changed the title ~~WIP core: use manged_path for running VMs with MBS devices~~ core: use manged_path for running VMs with MBS devices May 19, 2022

bennyz requested a review from sleviim May 19, 2022 12:41

bennyz force-pushed the mbs-run-path branch from c1d673e to c7a28af Compare May 23, 2022 12:25

bennyz removed the on hold label May 26, 2022

bennyz marked this pull request as ready for review May 26, 2022 08:07

bennyz requested review from ahadas, emesika, mwperina, michalskrivanek, oliel and sgratch as code owners May 26, 2022 08:07

bennyz requested a review from didib as a code owner May 26, 2022 08:07

nirs added this to the ovirt-4.5.1 milestone May 26, 2022

nirs reviewed May 26, 2022

View reviewed changes

nirs approved these changes Jun 1, 2022

View reviewed changes

bennyz merged commit 0e5d532 into oVirt:master Jun 2, 2022

bennyz deleted the mbs-run-path branch June 2, 2022 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: use manged_path for running VMs with MBS devices #104

core: use manged_path for running VMs with MBS devices #104

bennyz commented Feb 28, 2022

muliby-lb commented Apr 19, 2022

muliby-lb commented May 2, 2022

bennyz commented May 26, 2022

nirs left a comment

nirs May 26, 2022

bennyz May 29, 2022

nirs May 29, 2022

nirs Jun 1, 2022

nirs May 26, 2022

bennyz May 29, 2022

nirs May 26, 2022

nirs May 26, 2022

nirs May 26, 2022

bennyz May 29, 2022

nirs May 26, 2022

nirs Jun 1, 2022

		@@ -142,7 +142,9 @@ public VDSReturnValue attachManagedBlockStorageDisk(ManagedBlockStorageDisk disk

		@@ -76,6 +76,7 @@ private VDSReturnValue detachVolume() {
		AttachManagedBlockStorageVolumeVDSCommandParameters params =

core: use manged_path for running VMs with MBS devices #104

core: use manged_path for running VMs with MBS devices #104

Conversation

bennyz commented Feb 28, 2022

muliby-lb commented Apr 19, 2022

muliby-lb commented May 2, 2022

bennyz commented May 26, 2022

nirs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment