Ovirt engine 4.1.2.z #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Data Center cluster compatibility level is lower than the highest level supported by engine, display a warning icon in a new column in the Data Centers tab. Hovering over the column should show the alert message prompting the user to upgrade the data center. Change-Id: Ib0e4004c2834a314a707e62e5e7661a3e9c7c115 Bug-Url: https://bugzilla.redhat.com/1413150 Signed-off-by: Ravi Nori <rnori@redhat.com>
If the Cluster's cluster compatibility level is lower than the highest level supported by engine, display a warning icon in a new column in the Clusters tab. Hovering over the column should show the alert message prompting the user to upgrade the Cluster. Change-Id: I0f263ff9eddc89fc6b425aab87eb51927cba7c74 Bug-Url: https://bugzilla.redhat.com/1413150 Signed-off-by: Ravi Nori <rnori@redhat.com>
In commit I1e891ac39e , the columns job_id and step_id were removed from command_entities table, therefore they need to be removed from the taskcleaner script Change-Id: If2d1218667649e6a7efd8e933dfb9f91b59eb972 Bug-Url: https://bugzilla.redhat.com/1425705 Signed-off-by: Fred Rolland <frolland@redhat.com> (cherry picked from commit 4aa7884)
Change-Id: Ia2bb1b42452ea7ea5574505970e99d22b1f2f4e6 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
In hyperconverged mode: nfs = off, cifs = off optimize for virt = on Change-Id: I26f0a02eb39dd34e1975695dfecf0bde9e849edf Bug-Url: https://bugzilla.redhat.com/1420687 Signed-off-by: Sahina Bose <sabose@redhat.com>
Fix Affinity rule enforcer manager to dismiss hosted engine VMs when choosing VM candidates for migration. Change-Id: I83bcbc9ae0a70b078fcda377f17241892802873d Bug-Url: https://bugzilla.redhat.com/1421771 Signed-off-by: Yanir Quinn <yquinn@redhat.com> (cherry picked from commit 4106384)
Detect if the total memory or the number of CPUs were changed in the Edit dialog. If they were, NUMA nodes are changed to fit the new values. Change-Id: I67b796a128c0af17dd54056b862798cd0d650bcf Bug-Url: https://bugzilla.redhat.com/1291064 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> (cherry picked from commit 54fc01a)
…re changed" This reverts commit 9ce0636. Reverted commit on gerrit: https://gerrit.ovirt.org/#/c/69946/ Change-Id: Ic8b10a33a1bf50421527b25d19fc1f4606a4d70d Bug-Url: https://bugzilla.redhat.com/1291064 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com> (cherry picked from commit 5db67a7)
For migration or disaster recovery purposes we let the user filter out the hosted-engine hosts to redeploy from a backup on a different hosted-engine env. In order to be sure that all the hosted-engine runs with a local up-do-date configuration we have to remove them from the engine DB asking to the user to redeploy them to be sure that they point to the right hosted-engine storage domain. In order to remove them at restore time avoiding foreign key errors, we need to update all the existing VMs related to these hosts. Set status=Down, exit_reason=AdminShutdown, exit_status=Normal, run_on_vds=NULL, migrating_to_vds=NULL for all the VM that were running on the hosted-engine hosts we are filtering out at restore time. Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Bug-Url: https://bugzilla.redhat.com/1416466 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
… 4.0 Show a warning when setting deployment of hosted engine through the UI and the compatibility version of the cluster is less than 4.0 Change-Id: I15f4856558762507845055a0b88eac1e8f948d18 Bug-Url: https://bugzilla.redhat.com/1383156 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Restoring HE environment from backup could lead into two hosts, thinking they have spm_id==1 at same moment. One of those hosts will be newly deployed HE host with default spm_id==1, another one host will be old host from the database. This patch changes spm_id of the host with value '1' to some unused value. Change-Id: Ib7b10f57a9350adf3da73580c4a69e5ce317502e Bug-Url: https://bugzilla.redhat.com/1417518 Signed-off-by: Denis Chaplygin <dchaplyg@redhat.com> (cherry picked from commit b440a7e)
Fix installing logutils.jar on downstream build when using minimead.py which replaces pom version with specific version of the build. Change-Id: I2099186df489841b95d1a086a05f03e9bb525d9d Bug-Url: https://bugzilla.redhat.com/1408193 Signed-off-by: Martin Perina <mperina@redhat.com>
… 4.0 Removes the check to prevent deployment of HE on clusters with compatibility vesrion less than 4.0. The host must have repositories for ovirt 4.0 or newer, otherwise the deployment will fail. Change-Id: Iec29070e37058a3d02246e13563ad650a24bd6a1 Bug-Url: https://bugzilla.redhat.com/1383156 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
For migration or disaster recovery purposes we let the user filter out the hosted-engine storage domain and the engine VM to redeploy from a backup on a different hosted-engine env. Due to another bug the user could create a floating disk on the hosted-engine storage domain and then connect it to the engine VM. In this case we should still remove the hosted-engine storage domain filtering out other VMs disks as well without failing. Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Bug-Url: https://bugzilla.redhat.com/1416459 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Adding certificate url to UPLOAD_IMAGE_NETWORK_ERROR message. Change-Id: I66383147495d0d814b0e9959fc3314763d8003a1 Bug-Url: https://bugzilla.redhat.com/1425774 Signed-off-by: Daniel Erez <derez@redhat.com>
FileUpload widget: support translation for "Choose File" and "No file chosen" messages. Change-Id: I488ec54ecb5c630bc5570db2c079a60a625b0d76 Bug-Url: https://bugzilla.redhat.com/1356562 Signed-off-by: Daniel Erez <derez@redhat.com>
The more relevant changes in the new version of the model are the following: * Add IPv6 details to the `NicConfiguration` type. * Add NFS 4.2 support. The more relevant changes in the new version of the metamodel are the following: * Fix generation of XML and JSON descriptions for enum types. * Merge link with element if it has same name. Change-Id: Ic037208b32005cff18bef94b9d1bd3489dec6c18 Related-To: https://bugzilla.redhat.com/1424821 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
Previously there was no explicit timeout for communication to external network provider. This way there was a long timeout applied to the communication. Since some objects are locked during the communication, some objects was locked for a long period of time if the external network provided did not respond. An explicit timeout for the communication is added, to avoid locking for a long period of time. The library com.woorea.openstack is used for the communication with external network providers. The version of this library is increased to 3.1.2, which introduces the possibility to add the timeout for communication. Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Bug-Url: https://bugzilla.redhat.com/1380356 Signed-off-by: Dominik Holler <dholler@redhat.com> (cherry picked from commit 5f7c657)
Show a warning about recommendation of adding new volumes to scale out an HC cluster Change-Id: I1534ccbaab95dc386ba373877a7a0c6fb9de0f05 Bug-Url: https://bugzilla.redhat.com/1417582 Signed-off-by: Sahina Bose <sabose@redhat.com>
While creating a arbiter volume or adding bricks to arbiter volume, every third brick should be marked as arbiter brick Change-Id: I7161ebca6e262a7b2606817a940b399461fd8460 Bug-Url: https://bugzilla.redhat.com/1417101 Signed-off-by: Ramesh Nachimuthu <rnachimu@redhat.com> (cherry picked from commit e8a1110)
Renaming ImageProxyURL ConfigValue to ImageProxyAddress. This is mandatory for upgrading from 3.6 as ImageProxyURL has been removed in 4.0 and replaced with ImageProxyAddress. See: https://gerrit.ovirt.org/#/c/56231/ Change-Id: Ifee377bf1e2122e6265d250575c011ed7de269e6 Bug-Url: https://bugzilla.redhat.com/1426064 Signed-off-by: Daniel Erez <derez@redhat.com>
Modify the NewDiskModel of Direct LUN 'Read-Only' of value, the value should come from View, but not false. Change-Id: Ic68a1d3dcc91b1d186d4894dca0a34c34687fa16 Bug-Url: https://bugzilla.redhat.com/1425347 Signed-off-by: Tony Wang <Sline798@gmail.com>
SetupNetworksBondPopupView.updateBondOptions() updates the value of customBondEditor manually via the view. Setting the value this way doesn't fire any event. Therefore, the model is not updated during initialization. Moving updateBondOptions() and its registration to SetupNetworksBondModel fixes this behavior. Change-Id: I6a16a729633c3e1bd90a47689dbaffa9d5e813d8 Bug-Url: https://bugzilla.redhat.com/1424813 Signed-off-by: Dominik Holler <dholler@redhat.com> (cherry picked from commit d33523d)
The dependency of HostDevice feature on the `dedicated_vm_for_vds_list` was not reified in the respecitve scheduling filter - thus allowing errorneous attempts at Run or Migrate VM (that were bound to fail). Change-Id: I2653769f94d6c9209fd98c6fd524c5377fc590fb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1414970 Signed-off-by: Martin Betak <mbetak@redhat.com>
Debug packages requires same exact version of the runtime packages in order to properly work. Added explicit require ensuring that the version match. Concern has been raised related to eventual yum update error messages related to version locking: debug packages are not meant to be installed on any production environment other than for debugging purpose. Once the debug is finished they need to be removed. Change-Id: I77f1e509c7e0d8ed903ad33c154098c974e08c39 Bug-Url: https://bugzilla.redhat.com/1401963 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com> (cherry picked from commit 1406ba1)
- Fixed a few more labels that were not properly associated with their associated radio/checkboxes Change-Id: I1e27cfdc4c3cade5dc056c6e539e3aebbc82747a Bug-Url: https://bugzilla.redhat.com/1414418 Signed-off-by: Alexander Wels <awels@redhat.com>
- Fixed issue with ComboBox not working as before Change-Id: I5216d4de7bcb753d5715aac3833f663ad665b009 Bug-Url: https://bugzilla.redhat.com/1422779 Signed-off-by: Alexander Wels <awels@redhat.com>
Change-Id: I9b8a187c7805ece0796d7988d9b6a15c59be04d6 Bug-Url: https://bugzilla.redhat.com/1419967 Signed-off-by: Shahar Havivi <shaharh@redhat.com>
Change-Id: Ib8487e7cc5271d1ea17e6109b49bd6c6c51687aa Signed-off-by: Marcin Mirecki <mmirecki@redhat.com> Bug-Url: https://bugzilla.redhat.com/1422447
Required for bare metal to HE migration procedure. Also allow to quickly map VDSM's host_id to host in the engine. Change-Id: I07e8efdb31dc92bfa2958b7261fcde15e14c0bb4 Bug-Url: https://bugzilla.redhat.com/1417518 Signed-off-by: Denis Chaplygin <dchaplyg@redhat.com>
When a host is running jobs (and specifically storage jobs) we should block moving it to maintenance until the jobs are completed. This patch adds support to get the operations running on a host and adds a validation when it's moved to maintenance. The following changes are made: 1. Added stored procedure (with tests) that returns steps related to a subject entity. 2. Add validation in MaintenanceNumberOfVdssCommand. Regardless of this change, the validation is racey as a job (or a task) could be started after the validation. Locks should be added in order to sync between the maintenance flow and the start of jobs on a host. As this issue existed always, it'll be handled in a separate change - this patch adds the validation. Change-Id: Ibfa5947a39844b22bacf28f873bc6842bcf15040 Bug-Url: https://bugzilla.redhat.com/1444982 Signed-off-by: Liron Aravot <laravot@redhat.com>
When restoring a backup, the status and run_on_vds fields of the VM do not represent the actual information of the running VM. This may lead of unneeded restart of highly-available VMs that would cause a split-brain. Therefore, we decide to switch highly-available VMs to down when restoring a backup. But none of the existing exit reasons fit for this flow: Error would cause the VM to be restarted when the engine starts, and Normal doesn't reflect the situation properly since the VM was not shut-down properly. Thus, we add a new exit reason for this case, called Unknown. The whole purpose of this value, for now, is to prevent the automatic VM restart mechanism to skip VMs set with this value. Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Bug-Url: https://bugzilla.redhat.com/1441322 Signed-off-by: Arik Hadas <ahadas@redhat.com>
we want to notify the user if the customcompatibility version (CCV) is lower then the data center (DC). Change-Id: If24bfa9f7f8bf265b4f88ab4f51c61371508f4d5 Bug-Url: https://bugzilla.redhat.com/1436577 Signed-off-by: Shahar Havivi <shaharh@redhat.com>
Switch type(Experimental!) —> Switch type LEGACY —> Linux Bridge OVS —> OVS (experimental) Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Bug-Url: https://bugzilla.redhat.com/1438298 Signed-off-by: Martin Mucha <mmucha@redhat.com>
AsciiName validation is not required for volume as this is a volume entity selection Change-Id: I640936d741456bc13977946272a0c3afddf6ced6 Bug-Url: https://bugzilla.redhat.com/1440071 Signed-off-by: Sahina Bose <sabose@redhat.com>
The issue: - a VM is started on an older (pre 4.0) engine - in this engine, if the USB is configured as disabled, no USB device is sent to VDSM - libvirt reacts by creating a new unmanaged USB controller - this controller appears in engine as an unmanaged device - after updating the engine, update of all VMs is called to modify the devices according to the need of the new engine - this code adds a managed USB controller - in this stage, this VM has 2 USB controllers, one managed and one unmanaged - from this point, anytime the USB devices are about to be touched (e.g. creating a new template from this VM or from a snapshot of the VM) a sanity check checking that there is only 1 USB controller fails throwing an exception The fix is to detect that the unmanaged device is the one created by libvirt and adopt it as ours. Another issue: If there are two usb controller for the VM: * managed, unplugged * unmanaged, plugged and a snapshot is made and then previewed, the VM has two managed usb controllers. It is caused by the fact that OVF doesn't store 'managed' flag. To mitigate this, every time normal usb controllers are updated and there are more then one managed controller, all controllers are removed and the proper one is recreated. Change-Id: I74f516530e9be5887b12720f0cdaee4618a9e9c9 Bug-Url: https://bugzilla.redhat.com/1438188 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> Signed-off-by: Jakub Niedermertl <jniederm@redhat.com>
Action and type variables must be set in RemoveVmPoolCommand to be substituted in error messages. Change-Id: Id4a5065bc08aa97b63afcddd8c1b33452e7a218e Bug-Url: https://bugzilla.redhat.com/1418290 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
If VM is allocated to user from a VM Pool and the VM is not prestarted, lock is taken on it early to prevent race condition between AttachUserToVmFromPoolAndRunCommand and VmPoolMonitor. In regular flow, this lock is freed by RunVmCommand. But if validation of AttachUserToVmFromPoolAndRunCommand is failed or exception is thrown for some reason, this lock must be freed explicitly. Change-Id: I6d13d3196dd7e2557390675066e0b861071d846f Bug-Url: https://bugzilla.redhat.com/1433924 Bug-Url: https://bugzilla.redhat.com/1432105 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
Add an option --tmpdir=DIR to set the parent of the temporary directory that's created. Defaults to $TMPDIR if set, otherwise to /tmp. Change-Id: I13f07418329fd6347e3ec86f52438db220da393f Bug-Url: https://bugzilla.redhat.com/1445631 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
Forcing status on HA VMs at restore time to avoid the engine restarting them just after the restore with corruption risks. Change-Id: I8b90e54522ac294399db77317b6841ce810e8d88 Bug-Url: https://bugzilla.redhat.com/1446055 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Change-Id: I86517578a03e7227a3495cc287a4b85f64cf6467 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Change-Id: Ib04dda2541784027ee0d39c5d814e860247917e5 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Change-Id: Ib802ac8c0580aecd672326108a3cfbd4f80be7b1 Bug-Url: https://bugzilla.redhat.com/1445759 Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
CinderBroker extends AuditLoggableBase which relies on injected memebrs, and thus should have its members injected when new instances are created. Note: This is a 4.1 fix only. For the master branch, Id0c0b1efe0bdd1589c2d4f7bdccd6e5a4061eb65 provides a more elegant solution. Change-Id: I12e8b271daed0457f6f711cef5c4492b1eacb6cc Bug-Url: https://bugzilla.redhat.com/1448793 Signed-off-by: Allon Mureinik <amureini@redhat.com>
In some cases when running from compensation, task creation fails with NPE on addStep method of Step. In this patch when loading steps in JobRepositoryImpl, the steps list is not set if the list is null. Change-Id: Icd895174bfc48ca1087d53328cffa2b0b6191fca Bug-Url: https://bugzilla.redhat.com/1415691 Signed-off-by: Fred Rolland <frolland@redhat.com>
Bug-Url: https://bugzilla.redhat.com/1436983 Change-Id: I48449fd34008fe8e5d9df7d7703819d128b786c2 Signed-off-by: Alona Kaplan <alkaplan@redhat.com>
When adding a VM, a disk profile from wrong storage domain can be saved to the DB and cause problems in later commands. Change-Id: I8c1958edd21ef741c9ba061d4801cdc60f893e3b Bug-Url: https://bugzilla.redhat.com/1420258 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
ImportVmTemplateFromConfigurationCommand changed instance of #getVmTemplate() property without handling potential missing maxMemory attribute in some flows (importing Template from non-master data storage domain). Missing maxMemory property handling added. Change-Id: I8f579efd93f9a51ee8b819bd0598afb6d9ee1d18 Bug-Url: https://bugzilla.redhat.com/1444848 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com>
pki-enroll-request.sh is able to set the subjectAltName (SAN). The CA forum baseline requirements declares subjectAltName as required. Google Chrome seems to require the subjectAltName set in server certificates, and urllib3 generates warnings, if subjectaltName is not set. Change-Id: I022976407f0a8be14a6bde06da553c0d3348f7e7 Bug-Url: https://bugzilla.redhat.com/1449084 Signed-off-by: Dominik Holler <dholler@redhat.com> (cherry picked from commit d8a8f85)
TransferDiskImageCommand -> validateImageTransfer: The StorageDomainValidator should be created using the disk's storage domain id, as the new disk is already created. Currently, the domain id is fetched from command's parameters, which is available only when uplaoding from the WebAdmin. Change-Id: I801f71079e031367cf87b527ae2bf5c3bf1623e7 Bug-Url: https://bugzilla.redhat.com/1447023 Signed-off-by: Daniel Erez <derez@redhat.com>
If setting the RunAsyncActionCommand as the parent of the command being executed (original command), the original command "endAction" method isn't invoked, leaving it not completed. This change is valid for commands that could be run asynchronously. Change-Id: Iae4abd65206e4422f1758d8a258c8d36d265f192 Bug-Url: https://bugzilla.redhat.com/1447050 Signed-off-by: Ala Hino <ahino@redhat.com>
There is a different version of getHostListByCluster for webadmin and userportal. Both methods need to have parametrized AsyncCallback and have a converter callback configured. Change-Id: Iae7081e1fea497ec97af8577a0abc3740a8505cf Bug-Url: https://bugzilla.redhat.com/1448695 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com>
Change-Id: I3ee45529b4bf46506ea8f67c74bd68534a8613f7 Signed-off-by: Lev Veyde <lveyde@redhat.com>
Apache commons-logging libraries are reimplemented within WildFly. In older versions the reimplementation has been provided by 'org.slf4j.jcl-over-slf4j' module, but in newer version reimplementation has been changed to 'org.jboss.logmanager.commons.logging'. This works fine if application is executed inside running WildFly, but we are using those libraries also outside running EAP in command line tools. In order to be able to use slf4j as our logging frontend we are using standard slf4j implementation instead of WildFly reimplementation of slf4j for our command line tools. Apache commons-logging is used indirectly through commons-configuration also in command line tool engine-config, so we would need to add 'org.slf4j.jcl-over-slf4j' into our special modules for command line tools to override this reimplementation change. Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215 Bug-Url: https://bugzilla.redhat.com/1457900 Signed-off-by: Martin Perina <mperina@redhat.com>
Change-Id: Ib8e3e42cb65f8318f03e5a57cbdb56c553f21213 Signed-off-by: Martin Perina <mperina@redhat.com>
|
Hi, This is a read-only mirror of our gerrit based git. Please propose patches via Gerrit @ https://gerrit.ovirt.org/ |
|
The ovirt-engine GitHub repo is a read-only mirror from gerrit.ovirt.org/ovirt-engine. Instructions on how to push can be found on https://www.ovirt.org/develop/dev-process/working-with-gerrit/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.