Rename 'CreateAllSnapshotsFromVm' into 'CreateSnapshotForVm' leftovers #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barpavel
requested review from
sgratch,
ljelinkova,
bennyz,
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
barpavel
force-pushed
the
cleanup_CreateAllSnapshotsFromVm_leftovers
branch
from
0ce3c7a
to
77bf052
Compare
barpavel
commented
Apr 4, 2022
...n/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
Show resolved
Hide resolved
bennyz
approved these changes
Apr 5, 2022
ljelinkova
approved these changes
Apr 6, 2022
|
/ost |
A few years ago "CreateSnapshotForVm" command replaced the "CreateAllSnapshotsFromVm" command. See: https://gerrit.ovirt.org/c/ovirt-engine/+/87671 https://gerrit.ovirt.org/c/ovirt-engine/+/89559 Most of the code refactoring related to the command's renaming was performed then, but there were a few leftovers that existed till today. Finished the code refactoring to fix the misleading code. Signed-off-by: Pavel Bar <pbar@redhat.com> Change-Id: I9fdf59e9bdf3bd4fcd12df97da774b9a42f0327b
barpavel
force-pushed
the
cleanup_CreateAllSnapshotsFromVm_leftovers
branch
from
77bf052
to
8c501b8
Compare
|
/ost |
ahadas
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago
CreateSnapshotForVmcommand replaced theCreateAllSnapshotsFromVmcommand.See:
https://gerrit.ovirt.org/c/ovirt-engine/+/87671
https://gerrit.ovirt.org/c/ovirt-engine/+/89559
Most of the code refactoring related to the command's renaming was performed then.
But there were a few leftovers that existed till today.
Finished the code refactoring to fix the misleading code.
Signed-off-by: Pavel Bar pbar@redhat.com