-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: hide openidc related sensitive keys #240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
568aca6
to
69ff372
Compare
mwperina
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I did manual verification:
I don't think this patch deserves a computing power wasted on OST :) |
didib
reviewed
Apr 7, 2022
packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
Outdated
Show resolved
Hide resolved
didib
reviewed
Apr 7, 2022
69ff372
to
687d96b
Compare
Ensure that KEYCLOAK_DB_PASSWORD and EXTERNAL_OIDC_CLIENT_SECRET are not logged in plain text. Bug-Url: https://bugzilla.redhat.com/2021497
687d96b
to
ec71e43
Compare
Verified:
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the following properties are not logged in plain text:
Bug-Url: https://bugzilla.redhat.com/2021497