Null check in ClusterAdditionalStatusColumn #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinez
approved these changes
Apr 7, 2022
When rendering the ClusterAdditionalStatusColumn, the cluster.getHostNamesOutOfSync() might be null if the async backend query failed. As a result, we get the NP exception because we check only if the string is empty, not if it is null. This patch adds a null check to ClusterAdditionalStatusColumn::getEntityValue.
ljelinkova
force-pushed
the
fix-cluster-column
branch
from
24fa7c1
to
d064152
Compare
|
/ost |
ahadas
approved these changes
Apr 11, 2022
ahadas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering the ClusterAdditionalStatusColumn, the cluster.getHostNamesOutOfSync() might be null if the
async backend query failed. As a result, we get the NP exception because we check only if the string is empty, not if it is null. This patch adds a null check to ClusterAdditionalStatusColumn::getEntityValue.