Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: keycloak db backup/restore #251

Merged
merged 1 commit into from
May 11, 2022
Merged

packaging: keycloak db backup/restore #251

merged 1 commit into from
May 11, 2022

Conversation

arso
Copy link
Contributor

@arso arso commented Apr 8, 2022 •
edited

This patch introduces a backup/restore functionality for internally
bundled keycloak database.

Depends on: oVirt/ovirt-engine-keycloak#35

@arso arso marked this pull request as draft April 8, 2022 12:43
didib
didib reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@didib didib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks ok. Please verify also restore from a 4.4 backup.

packaging/bin/engine-backup.sh.in Outdated Show resolved Hide resolved
@arso arso force-pushed the keycloak-backup branch 3 times, most recently from adfb8f9 to 91e66f6 Compare May 9, 2022 10:07
@arso arso mentioned this pull request May 9, 2022
Merged
@arso arso marked this pull request as ready for review May 9, 2022 11:20
@arso arso added this to the ovirt-4.5.1 milestone May 9, 2022
@arso arso self-assigned this May 9, 2022
@arso
Copy link
Contributor Author

arso commented May 9, 2022

OST was good: https://rhv-devops-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/ds-ost-baremetal_manual/36447/console

@arso arso force-pushed the keycloak-backup branch 2 times, most recently from a673736 to ec45394 Compare May 10, 2022 07:05
@arso arso marked this pull request as draft May 10, 2022 07:30
@arso
Copy link
Contributor Author

arso commented May 10, 2022 •
edited

Turning it to draft because I found one incorrect flow. When backup is created from setup without keycloak db and then engine is upgraded to support keycloak (with keycloak setup packages installed) the restore fails because it attempts to restore non-existent keycloak_backup.db from tgz. In such case keycloak db restoration should be skipped.

Update: @didib proved me I had incorrect script version installed that caused this error. Other words 'works fine and as expected'

@arso arso marked this pull request as ready for review May 10, 2022 09:21
@arso
Copy link
Contributor Author

arso commented May 10, 2022

/ost

@arso
Copy link
Contributor Author

arso commented May 10, 2022 •
edited

I think ost failed because there was an older version of keycloak (without oVirt/ovirt-engine-keycloak#35)

@arso
Copy link
Contributor Author

arso commented May 10, 2022

/ost

@arso
Copy link
Contributor Author

arso commented May 11, 2022

/ost

@arso
packaging: keycloak db backup/restore
8d8d2c6 
This patch introduces a backup/restore functionality for internally
bundled keycloak database.

!!!
!!! Do not merge it  because it is still under heavy development / draft
!!!
mwperina
mwperina approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit 1a1067b into oVirt:master May 11, 2022
@arso arso deleted the keycloak-backup branch May 11, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didib didib didib approved these changes

@mwperina mwperina mwperina approved these changes

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@oliel oliel Awaiting requested review from oliel

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

Assignees

@arso arso

Labels
None yet
Projects
None yet
Milestone
ovirt-4.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arso @didib @mwperina