-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix FIPS handling #255
fix FIPS handling #255
Conversation
/ost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error we saw in OST was because the data saving happened after calling HandleVdsFips (which took it from getVds()
) and wasn't updated?
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Outdated
Show resolved
Hide resolved
I didn't get to the bottom of that - but this certainly didn't help |
The idea behind using VdsEventListener is to propagate events at the vdsbroker layer to the bll layer. Now that the trigger to initiate HandleVdsFips is InitVdsOnUp, we no longer need it. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Now that we check the host FIPS mode (compared to the cluster's mode) in InitVdsOnUp, we need to take special care about the VDS object we check since InitVdsOnUp is called before persisting the data that is received by the host monitoring. So instead of passing the reported data to HandleVdsFips, it would be simpler to inline HandleVdsFips into InitVdsOnUp - we have everything accessible there and we can reuse some existing code to set the non-operational mode, if needed. Bug-Url: https://bugzilla.redhat.com/2065543 Signed-off-by: Arik Hadas <ahadas@redhat.com>
Also do that before initialize the storage domains as checking the FIPS mode compared to the cluster's mode is much simpler. Signed-off-by: Arik Hadas <ahadas@redhat.com>
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Now that we check the host FIPS mode (compared to the cluster's mode) in InitVdsOnUp, we need to take special care about the VDS object we check since InitVdsOnUp is called before persisting the data that is received by the host monitoring. So instead of passing the reported data to HandleVdsFips, it is simpler to inline HandleVdsFips into InitVdsOnUp - we have everything accessible there and we can reuse some existing code to set the non-operational mode, if needed.
Bug-Url: https://bugzilla.redhat.com/2065543