-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine_setup: cleanup after ARS removal #257
Conversation
e91ebc1
to
478a053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix python linter issues, other than that it looks good to me
Fixed |
@@ -0,0 +1,86 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to ars_cleanup.py
to clear mentioned it's related to ansible-runner-service and not ansible-runner
# | ||
|
||
|
||
"""Apache ansible-runner plugin.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache ansible-runner-service cleanup plugin
|
||
@util.export | ||
class Plugin(plugin.PluginBase): | ||
"""Cleanup of the ansible-runner plugin.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apache ansible-runner-service cleanup plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/ost |
Removal of ansible-runner-service constants from engine_setup.