-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host-deploy: condition for adding fapolicy rules #258
Merged
mwperina
merged 2 commits into
oVirt:ovirt-engine-4.5.0.z
from
mwperina:fapolicy-rule-backport
Apr 14, 2022
Merged
host-deploy: condition for adding fapolicy rules #258
mwperina
merged 2 commits into
oVirt:ovirt-engine-4.5.0.z
from
mwperina:fapolicy-rule-backport
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d938852
to
9257767
Compare
sandrobonazzola
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9257767
to
651e539
Compare
arachmani
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
remove ansible_distribution == 'RedHat' since we already check if the service is running. fapolicyd < 1.1 doesn't have /etc/fapolicyd/rules.d/,add check if the directory exists.
Fixes fapolicy configuration path introduced in oVirt#256 Signed-off-by: Martin Perina <mperina@redhat.com>
651e539
to
3c6d211
Compare
sandrobonazzola
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove ansible_distribution == 'RedHat' since we already check if the service is running.
fapolicyd < 1.1 doesn't have /etc/fapolicyd/rules.d/,add check if the directory exists.
Backport of #256 and #259 into ovirt-engine-4.5.0.z