Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: always update volume size when creating a new image #267

Merged
merged 2 commits into from
May 19, 2022
Merged

core: always update volume size when creating a new image #267

merged 2 commits into from
May 19, 2022

Commits on May 17, 2022

  1. core: use content type to determine memory disks 

    Since we have the disk_content_type field we can use it to distinguish
between the two memory related disks instead of checking the size.

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
    @bennyz
    bennyz committed May 17, 2022
    Configuration menu
    Copy the full SHA
    e834d72 View commit details
    Browse the repository at this point in the history

  2. core: always update volume size when creating a new image 

    Vdsm often aligns the size of the volume when creating, and the volume
will end up having a different size in the engine than what is on the
storage. This is already handled when a new disk is created but not when
a new snapshot is created.

Since there is already a getVolumeInfo request at the end of snapshot
creation, we can use this opportunity to update the size of the volume
as well.

Bug-Url: https://bugzilla.redhat.com/1852308
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
    @bennyz
    bennyz committed May 17, 2022
    Configuration menu
    Copy the full SHA
    e03dcb5 View commit details
    Browse the repository at this point in the history