Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n+welcome+webadmin: Add support for Georgian language as a community translation #269

Merged
merged 1 commit into from
Jun 9, 2022
Merged

i18n+welcome+webadmin: Add support for Georgian language as a community translation #269

merged 1 commit into from
Jun 9, 2022

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Apr 13, 2022 •
edited
Loading

Locale "ka_GE"

Support needs to be added in 3 places:

  • welcome page via language.properties so it is user selectable
  • GWT build options to include the new locale as an included permutation for a BUILD_LOCALES=1 build
  • i18n scripts to pull the translations

Related changes:

Zanata link: https://zanata.ovirt.org/iteration/view/ovirt-engine/ovirt-4.5/languages/ka
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2075188

@sjd78 sjd78 added the UX label Apr 13, 2022
@sjd78 sjd78 requested a review from rszwajko April 13, 2022 19:22
This was referenced Apr 13, 2022
Merged
Merged
sandrobonazzola
sandrobonazzola approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola sandrobonazzola modified the milestone: ovirt-4.5.1 Apr 14, 2022
rszwajko
rszwajko reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When new locale is provided via URL /ovirt-engine/webadmin/?locale=ka_GE then it's correctly recognized by ui-extensions (dashboard, dialogs).

@sjd78
I had problems with selecting the Georgian locale on the welcome page (locale is back to defaults). Is it the expected behaviour when no translations are (yet) provided for web admin?

@rszwajko rszwajko self-requested a review April 19, 2022 18:09
@sjd78
Copy link
Member Author

sjd78 commented Apr 19, 2022

When new locale is provided via URL /ovirt-engine/webadmin/?locale=ka_GE then it's correctly recognized by ui-extensions (dashboard, dialogs).

@sjd78 I had problems with selecting the Georgian locale on the welcome page (locale is back to defaults). Is it the expected behaviour when no translations are (yet) provided for web admin?

Some strange things can happen in dev environments when building webadmin with different locales. Best bet is to:

  1. make sure either BUILD_LOCALES=1 is set on your build OR -Dgwt.locale=en_US,ka_GE as part of a build options var,
  2. use a clean browser tab (private or incognito work good)
  3. use the drop down on the welcome page to select the locale
  4. make sure your user doesn't have a default locale set in user preferences

With pulled Georgian translations and webadmin build with -Dgwt.locale=en_US,ka_GE I get:
screenshot-engine-dev ovirt_8443-2022 04 19-14_01_21
oVirt - ღია ვირტუალიზაციის მმართველი - Google Chrome_001
oVirt - ღია ვირტუალიზაციის მმართველი - Google Chrome_002

@sjd78 sjd78 force-pushed the enable_georgian branch 3 times, most recently from b9cbb03 to d6f5a8c Compare April 21, 2022 16:13
@sjd78 sjd78 requested a review from emesika April 21, 2022 17:11
@sjd78 sjd78 force-pushed the enable_georgian branch 3 times, most recently from a5d2226 to 34dfe70 Compare May 9, 2022 17:32
@sjd78
Copy link
Member Author

sjd78 commented May 9, 2022

@emesika - I've update the languages.properties files again. Everything should be good to go.

@sjd78 sjd78 force-pushed the enable_georgian branch 3 times, most recently from beee041 to 4e2cc04 Compare May 16, 2022 13:37
@sjd78 sjd78 force-pushed the enable_georgian branch 2 times, most recently from d392315 to bf03a7a Compare May 23, 2022 16:28
@sandrobonazzola sandrobonazzola self-requested a review May 24, 2022 06:49
sandrobonazzola
sandrobonazzola approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola sandrobonazzola dismissed emesika’s stale review May 24, 2022 06:50

requested changes have been included in latest patch set

emesika
emesika approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@emesika emesika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola
Copy link
Member

@sgratch I think this is ready to be merged.

@sjd78
Add support for Georgian language as a community translation
551bbfc 
Locale "ka_GE"

Support needs to be added in 3 places:

  - welcome page via language.properties so it is user selectable

  - GWT build options to include the new locale as an included
    permutation for a `BUILD_LOCALES=1` build

  - i18n scripts to pull the translations
@michalskrivanek michalskrivanek merged commit 2eb09e3 into oVirt:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrobonazzola sandrobonazzola sandrobonazzola approved these changes

@emesika emesika emesika approved these changes

@rszwajko rszwajko rszwajko approved these changes

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@ljelinkova ljelinkova Awaiting requested review from ljelinkova

@didib didib Awaiting requested review from didib didib is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@bennyz bennyz Awaiting requested review from bennyz bennyz is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@oliel oliel Awaiting requested review from oliel

Assignees
No one assigned
Labels
UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sjd78 @sandrobonazzola @emesika @rszwajko @michalskrivanek