Fix wrong dedicated migration assignments #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking a migration the `cpusets` is sent to VDSM as a list. The index of each list represents the virtual CPU and the value is the physical CPU we are taking. Sorting the values is wrong, as it results a wrong mapping, causing split cores and split sockets. Change-Id: Ib5d2d178557fa3f9e0130325f52e8cf6e8a04970 Bug-Url: https://bugzilla.redhat.com/2075037 Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
liranr23
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking a migration the cpusets is sent to VDSM as a list. The index of each list represents the virtual CPU and the value is the physical CPU we are taking. Sorting the values is wrong, as it results a wrong mapping, causing split cores and split sockets.
Bug-Url: https://bugzilla.redhat.com/2075037