Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of the response of get capabilities #279

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Apr 14, 2022

This PR improves handleRefreshCapabilitiesResponse:

  1. It first tries to process the response of get-capabilities, if that fails - it immediately logs that and returns an error
  2. Only later it tries to get hardware data - if we manage to get a valid response from get-capabilities, it will most likely succeed with that but if not - we log that and continue because we hold the more important data already
  3. The code that updates the database and notifies other components that we managed to refresh the host capabilities no longer runs within the same if-block that generates an error related to get-capabilities upon failure (but an appropriate exception would bubble up)

@ahadas
Copy link
Member Author

ahadas commented Apr 14, 2022

/ost

1 similar comment
@ahadas
Copy link
Member Author

ahadas commented Apr 14, 2022

/ost

@ahadas
Copy link
Member Author

ahadas commented Apr 15, 2022

/ost

@ahadas ahadas added the OST label Apr 18, 2022
@ahadas ahadas merged commit f9e239d into oVirt:master Apr 19, 2022
@ahadas ahadas deleted the ost_is_fun branch April 19, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants