-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VmBackupStop async using flag #281
Conversation
...odules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBackupPhase.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
65678a6
to
83a2a17
Compare
83a2a17
to
5fe0d24
Compare
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
5fe0d24
to
b9f9d42
Compare
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Show resolved
Hide resolved
b9f9d42
to
4ce7595
Compare
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
...ger/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBackup.java
Outdated
Show resolved
Hide resolved
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBackupDaoImpl.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Show resolved
Hide resolved
4ce7595
to
42db7a5
Compare
After investigating what happens when HybridBackup is finalized during active image transfer - found that the RemoveSnapshotCommand fails validation
Then, HybridBackup command goes to endWithFailure, and then the same flow as in https://bugzilla.redhat.com/2080766 happens. The transfer remains active, Auto-Generated is left hanging. Fixing the mentioned bug would handle the command ending, also leaving an audit log entry regarding snapshot leftover |
maybe the transfers were previously (with the old mechanism) stopped when we issued the call to |
42db7a5
to
189a4c5
Compare
189a4c5
to
8cd2ce5
Compare
8cd2ce5
to
5dbb3d4
Compare
5dbb3d4
to
8a54b69
Compare
/ost |
Currently StopVmBackup command changed VM Backup phase in order to stop/finalize backup. This patch changes StopVmBackupCommand to set a flag on the backup entity that it is stopped (only for Hybrid backup), and then as HybridBackupCommand detects that the flag was raised and finalizes the Backup accordingly.
8a54b69
to
b6aa1bd
Compare
Currently StopVmBackup command changed VM Backup phase in order to
stop/finalize backup.
This patch changes StopVmBackupCommand to set a flag on the backup
entity that it is stopped (only for Hybrid backup), and then
HybridBackupCommand detects that the flag was raised and finalizes
the Backup accordingly.
But-Url: https://bugzilla.redhat.com/1900552