Make VmBackupStop async using flag #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
reviewed
Apr 17, 2022
...odules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBackupPhase.java
Outdated
Show resolved
Hide resolved
bennyz
reviewed
Apr 17, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
bennyz
reviewed
Apr 17, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
65678a6
to
83a2a17
Compare
ahadas
changed the title
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
83a2a17
to
5fe0d24
Compare
bennyz
reviewed
Apr 18, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Outdated
Show resolved
Hide resolved
ahadas
reviewed
Apr 19, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
5fe0d24
to
b9f9d42
Compare
bennyz
reviewed
Apr 19, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java
Show resolved
Hide resolved
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
b9f9d42
to
4ce7595
Compare
mkemel
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
reviewed
Apr 28, 2022
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Outdated
Show resolved
Hide resolved
...ger/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBackup.java
Outdated
Show resolved
Hide resolved
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBackupDaoImpl.java
Outdated
Show resolved
Hide resolved
.../modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/StopVmBackupCommand.java
Show resolved
Hide resolved
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
4ce7595
to
42db7a5
Compare
|
After investigating what happens when HybridBackup is finalized during active image transfer - found that the RemoveSnapshotCommand fails validation Then, HybridBackup command goes to endWithFailure, and then the same flow as in https://bugzilla.redhat.com/2080766 happens. The transfer remains active, Auto-Generated is left hanging. Fixing the mentioned bug would handle the command ending, also leaving an audit log entry regarding snapshot leftover |
ahadas
approved these changes
May 3, 2022
maybe the transfers were previously (with the old mechanism) stopped when we issued the call to |
ahadas
force-pushed
the
improve_vm_backup_stop
branch
from
42db7a5
to
189a4c5
Compare
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
189a4c5
to
8cd2ce5
Compare
ahadas
force-pushed
the
improve_vm_backup_stop
branch
from
8cd2ce5
to
5dbb3d4
Compare
bennyz
approved these changes
May 9, 2022
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
5dbb3d4
to
8a54b69
Compare
aesteve-rh
approved these changes
May 10, 2022
|
/ost |
Currently StopVmBackup command changed VM Backup phase in order to stop/finalize backup. This patch changes StopVmBackupCommand to set a flag on the backup entity that it is stopped (only for Hybrid backup), and then as HybridBackupCommand detects that the flag was raised and finalizes the Backup accordingly.
mkemel
force-pushed
the
improve_vm_backup_stop
branch
from
8a54b69
to
b6aa1bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently StopVmBackup command changed VM Backup phase in order to
stop/finalize backup.
This patch changes StopVmBackupCommand to set a flag on the backup
entity that it is stopped (only for Hybrid backup), and then
HybridBackupCommand detects that the flag was raised and finalizes
the Backup accordingly.
But-Url: https://bugzilla.redhat.com/1900552