Fix query in single GET disksnapshot request #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
requested review from
aesteve-rh,
ahadas,
ArtiomDivak,
barpavel,
bennyz and
sleviim
ahadas
changed the title
ahadas
approved these changes
Apr 18, 2022
ahadas
force-pushed
the
fix_get_disk_snapshot_query
branch
from
e3de372
to
7c5a3a0
Compare
sleviim
approved these changes
Apr 19, 2022
Fixing GET api/disks/{diskid}/disksnapshots/{snapshotid}:
Return correct snapshot, when more than one snapshot existed
for the disk. Incorrect query (GetAllDiskSnapshots) was used to fetch
a single snapshot. Now using GetDiskSnapshotByImageId instead.
Bug-Url: https://bugzilla.redhat.com/2013696
mkemel
force-pushed
the
fix_get_disk_snapshot_query
branch
from
7c5a3a0
to
36b9a25
Compare
emesika
approved these changes
Apr 20, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing GET api/disks/{diskid}/disksnapshots/{snapshotid}:
Return correct snapshot, when more than one snapshot existed
for the disk. Incorrect query (GetAllDiskSnapshots) was used to fetch
a single snapshot. Now using GetDiskSnapshotByImageId instead.
Bug-Url: https://bugzilla.redhat.com/2013696