core: Fix time units for ansible async timeout #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
requested review from
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
just need to correlate this with https://bugzilla.redhat.com/show_bug.cgi?id=2076474, other than that, lgtm |
We have added async processing with a timeout as a part of oVirt#116 which should use the default Ansible playbook execution timeout specified by ANSIBLE_PLAYBOOK_EXEC_DEFAULT_TIMEOUT engine option. Unfortunately we forgot to convert time units of ANSIBLE_PLAYBOOK_EXEC_DEFAULT_TIMEOUT (specified in minutes) to seconds expected by async keyword inn ansible. Bug-Url: https://bugzilla.redhat.com/2076474 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
fix-ansible-async-timeout
branch
from
39c3f1a
to
395d6d3
Compare
ahadas
approved these changes
Apr 19, 2022
|
/ost |
michalskrivanek
changed the title
|
/ost |
michalskrivanek
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added async processing with a timeout as a part of #116 which should use the default Ansible playbook execution timeout specified by ANSIBLE_PLAYBOOK_EXEC_DEFAULT_TIMEOUT engine option. Unfortunately we forgot to convert time units of ANSIBLE_PLAYBOOK_EXEC_DEFAULT_TIMEOUT (specified in minutes) to seconds expected by async keyword in ansible.
Bug-Url: https://bugzilla.redhat.com/2076474
Signed-off-by: Martin Perina mperina@redhat.com