Improve MAVEN build Performance #29
Conversation
|
hi @ChenZhangg. Many thanks for looking into this area which, I think, needs some more love :) |
|
@ChenZhangg can you please follow up to @arso comment? |
sandrobonazzola
force-pushed
the
Modify_MAVEN_1
branch
from
1722b65
to
24a4fb3
Compare
sandrobonazzola
requested review from
mwperina,
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
There was a problem hiding this comment.
I have tested that change locally and it seem ok - personally I has been running builds with '-T1C' (one thread per core) option for more than a year now. This is enabled here for travis and I see that checks are passing which means that it is safe to merge it.
I have left few comments regarding formatting. Once these are resolved I am happy to give my +1
| @@ -856,6 +864,9 @@ | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <configuration> | |||
| <testFailureIgnore>true</testFailureIgnore> | |||
| <parallel>classes</parallel> | |||
There was a problem hiding this comment.
Please fix formatting to match the line above - use 2 instead of 1 space. Same for the line below
| @@ -844,6 +847,11 @@ | |||
| <plugins> | |||
| <plugin> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <configuration> | |||
| <parallel>classes</parallel> | |||
There was a problem hiding this comment.
Please fix formatting to match the line above - use 2 instead of 1 space. Same for the line below
| @@ -619,6 +619,9 @@ | |||
| <configuration> | |||
| <reportsDirectory>${ovirt.surefire.reportsDirectory}</reportsDirectory> | |||
| <argLine>--illegal-access=permit</argLine> | |||
| <parallel>classes</parallel> | |||
There was a problem hiding this comment.
Please fix formatting to match the line above - use 2 instead 3 spaces. Same for the line below
|
@ChenZhangg can you please follow up? |
Parallel builds in Maven 3 Maven 3.x has the capability to perform parallel builds.
According to Maven parallel test, we can run tests in parallel.
=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.