Handle many vCPUs #293
Merged
Handle many vCPUs #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...broker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
Outdated
Show resolved
Hide resolved
...vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
Outdated
Show resolved
Hide resolved
michalskrivanek
requested changes
Apr 21, 2022
...vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
Outdated
Show resolved
Hide resolved
|
great, LGTM |
Seems to be working (as for value in the domain.xml). NVDIMM calculation wasn't tested. |
mz-pdm
requested review from
ahadas,
bennyz,
emesika,
mwperina,
oliel,
sgratch and
didib
as code owners
liranr23
approved these changes
Apr 25, 2022
ahadas
reviewed
Apr 25, 2022
...vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
Outdated
Show resolved
Hide resolved
...vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
Outdated
Show resolved
Hide resolved
...vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
Outdated
Show resolved
Hide resolved
...vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
Outdated
Show resolved
Hide resolved
|
Additionally the hard max vCPU limit is not strictly enforced again, it can be lifted up to LEGACY_MAX_SOCKETS based value again unless the newly introduced limit ManyVmCpus is exceeded. Not yet tested and tests fail (due to missing mockings). I don't know how to put the PR back to draft status. |
|
Tests fixed. |
With the lifted limit on the maximum number of CPU sockets implemented in commit a4c0858, the maximum possible number of vCPUs increased significantly. But it is not without its price. The increased maximum number of vCPUs reduces memory available to the guest OS and may cause some problems, especially with UEFI firmware. There is already MaxNumOfCpusCoefficient config value limiting the maximum number of vCPUs. But it is not enforced strictly, the maximum number of vCPUs can still be significantly higher, to be consistent with the previous behavior. Let’s be more cautious and clearer and apply MaxNumOfCpusCoefficient strictly, unless the maximum number of vCPUs is not very large, in the sense of the newly introduced ManyVmCpus config value. Bug-Url: https://bugzilla.redhat.com/2075486
Large VMs using UEFI may not start if the TSEG size is not big enough. There is no clear rule when the TSEG size must be increased. We increase it in the following cases: - If the maximum number of VM vCPUs is at least 128. - If the maximum memory is at least 16 GB, i.e. the memory taken from the guest by changing the TSEG size is negligible. We increase the TSEG size by wild-guess values based on various comments from Bugzilla, see the comment in the code for more details. As the TSEG size is taken from the memory available to the guest, we do not want to make it unnecessarily large by default. On the other hand, it’s better to be on the safe side and allocate a bit more than perhaps needed rather than causing the VM not to start. We introduce config values for both the limits mentioned above, in case the selected values don’t work well enough. Bug-Url: https://bugzilla.redhat.com/2075486
|
Verified: Quite many combinations to check but I believe it produces expected domain XMLs. |
ahadas
approved these changes
Apr 26, 2022
|
/ost |
|
LGTM |
michalskrivanek
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more details.
Bug-Url: https://bugzilla.redhat.com/2075486