Handle NULL in default/actual values in vdc_options #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
reviewed
Apr 24, 2022
packaging/dbscripts/upgrade/04_05_0100_fix_04_04_0050_set_to_not_null.sql
Show resolved
Hide resolved
emesika
requested changes
Apr 25, 2022
packaging/dbscripts/upgrade/04_05_0100_fix_04_04_0050_set_to_not_null.sql
Show resolved
Hide resolved
We have discovered that some users still have some ancient options present in vdc_options (even though they should be removed now), which contains NULL in default/actual values. We have fixed fn_db_change_column_type to properly set NULL/NOT NULL constraints in https://gerrit.ovirt.org/117448 , but we missed above that ancient options mentioned above still could exist, so we need to fix those NULL default/actual values before setiing NOT NULL constrain. Bug-Url: https://bugzilla.redhat.com/2077387 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
handle-null-default-values-backport
branch
from
58c4bf8
to
5ff0a06
Compare
michalskrivanek
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have discovered that some users still have some ancient options
present in vdc_options (even though they should be removed now), which
contains NULL in default/actual values.
We have fixed fn_db_change_column_type to properly set NULL/NOT NULL
constraints in https://gerrit.ovirt.org/117448 , but we missed above
that ancient options mentioned above still could exist, so we need to
fix those NULL default/actual values before setiing NOT NULL constrain.
Bug-Url: https://bugzilla.redhat.com/2077387
Signed-off-by: Martin Perina mperina@redhat.com