Fix dedicated pending resources #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljelinkova
requested review from
sgratch,
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel and
didib
as code owners
ljelinkova
force-pushed
the
fix-dedicated-pending-resources
branch
from
a069ade
to
3640d84
Compare
ahadas
approved these changes
Apr 27, 2022
|
/ost |
liranr23
approved these changes
Apr 27, 2022
When there is no host found where the VM can run, the following message is displayed: The host ABC did not satisfy internal filter CpuPinning because... It makes sense to continue with "it" after that. Also, in case of manual and resize and pin pinning, we should mention also the possibility that some cores have been exclusively pinned.
…pinnings In CpuPinningPolicyUnit, we need to apply the pending vds cpu resources also for manual and resize and pin policies. Otherwise we may end up with both, manual (or resize and pin) and dedicated vCPU pinned to a single pCPU.
In VdsCpuUnitPinningHelper::previewPinOfPendingExclusiveCpus, the CPU topology has been updated with an incorrect CPU pinning policy (the current VM's instead of the pending one). This may have caused that after the migration of a VM group with mixed exclusive and manual pinnings, some CPUs might end up to be pinned to both, manual and exclusive CPUs at once.
ljelinkova
force-pushed
the
fix-dedicated-pending-resources
branch
from
3640d84
to
f5835a0
Compare
|
/ost |
1 similar comment
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the migration of a VM group with mixed exclusive and manual pinnings, some pCPUs might have ended up to be pinned to both, manual and exclusive vCPUs at once. This was caused by the fact that the pending vds cpu unit resources have not been applied for non exclusively pinned CPUs and that the application of the pending resources has not been correct (the current VM's cpu pinning policy was used instead of the pending one).