packaging: Renew expiring vmconsole certificates #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
approved these changes
Apr 25, 2022
In commit 35e8f51, a check was added to renew vmconsole certificates when the CA certificate is newer. But the certificates are still not renewed if they are expired or close to being expired. Let’s fix it by additionally checking for certificate expiration. In order to that, we must check the helper certificate file instead of key. Bug-Url: https://bugzilla.redhat.com/1988496
ahadas
force-pushed
the
vmconsole-certs-backport
branch
from
d6dbe14
to
1a40b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 35e8f51, a check was added
to renew vmconsole certificates when the CA certificate is newer. But
the certificates are still not renewed if they are expired or close to
being expired. Let’s fix it by additionally checking for certificate
expiration.
In order to do that, we must check the helper certificate file instead of
key.
Bug-Url: https://bugzilla.redhat.com/1988496