intl: Add missing localized enum #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ost |
1 similar comment
|
/ost |
sjd78
approved these changes
Apr 26, 2022
ljelinkova
approved these changes
Apr 28, 2022
When testing engine UI with Selenium in the Firefox console we can see:
console.warn: "Mon Apr 25 13:07:02 GMT+000 2022 org.ovirt.engine.ui.uicompat.EnumTranslator
WARNING: Missing Enum resource 'V4_2'. Cannot find constant 'NfsVersion___V4_2';
expecting a method name"
Let's add the java enum entry to match the one defined in the properties
file [1].
[1] https://github.com/oVirt/ovirt-engine/blob/27a8d1c3f678ef9efc9a300da8cc3c8a8c1afef0/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties#L620
Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
ljelinkova
force-pushed
the
add-missing-enum
branch
from
da23e04
to
65ac605
Compare
ahadas
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing engine UI with Selenium in the Firefox console we can see:
console.warn: "Mon Apr 25 13:07:02 GMT+000 2022 org.ovirt.engine.ui.uicompat.EnumTranslator
WARNING: Missing Enum resource 'V4_2'. Cannot find constant 'NfsVersion___V4_2';
expecting a method name"
Let's add the java enum entry to match the one defined in the properties
file [1].
[1]
ovirt-engine/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
Line 620 in 27a8d1c
Signed-off-by: Marcin Sobczyk msobczyk@redhat.com