-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check vdsm is not installed only during host deploy #317
Merged
mwperina
merged 9 commits into
oVirt:master
from
dangel101:B2055136_virt_module_not_changed
May 3, 2022
Merged
check vdsm is not installed only during host deploy #317
mwperina
merged 9 commits into
oVirt:master
from
dangel101:B2055136_virt_module_not_changed
May 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
av is already set on ovirt-host-deploy-facts which is executed during host upgrade
mwperina
requested changes
May 2, 2022
...ging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts/tasks/av-setup.yml
Outdated
Show resolved
Hide resolved
1. set virt_mod_ver according to the future version (latest_rh_rhel) 2. execute av-setup only on host deploy
mwperina
reviewed
May 2, 2022
...ging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts/tasks/av-setup.yml
Outdated
Show resolved
Hide resolved
mwperina
approved these changes
May 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please add a verification finished comment, so we can merge afterwards
verified upgrading from 8.5 to 8.6 |
mwperina
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct virt DNF module version during host upgrade flow to aling with RHEL version that host is being upgraded to.
Bug-Url: https://bugzilla.redhat.com/2055136