Mark HybridBackup succeeded when snapshot removal fails #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
requested review from
bennyz,
ahadas,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
mkemel
changed the title
bennyz
approved these changes
May 4, 2022
ahadas
approved these changes
May 7, 2022
This fixes the issue, that when during HybridBackup finalization snapshot remove is failed - the backup is marked as FAILED, although it should be marked as SUCCEEDED. Also, added an audit log about possible snapshot leftover. Bug-Url: https://bugzilla.redhat.com/2080766
ahadas
force-pushed
the
hybrid_backup_snapshot_remove_fail
branch
from
693ba29
to
8d7038e
Compare
Bug-Url: https://bugzilla.redhat.com/2080766 Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
changed the title
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue, that when snapshot removal fails during HybridBackup finalization, the backup is marked as FAILED, although it should have been marked as SUCCEEDED. Also, added an audit log about possible snapshot leftover.
Bug-Url: https://bugzilla.redhat.com/2080766