-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webadmin: update OpenSans fonts bundled with PF3 #337
Conversation
Changed fonts: 1. OpenSans-*.ttf - downloaded from OpenSans GitHub project 2. OpenSans-*.woff2 - generated from TTF using woff2_compress 3. OpenSans-*.woff - generated from TTF using sfnt2woff-zopfli Reference-Url: googlefonts/opensans@ebedbda Reference-Url: https://github.com/google/woff2 Reference-Url: https://packages.debian.org/unstable/sfnt2woff-zopfli Bug-Url: https://bugzilla.redhat.com/2065068
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rszwajko did you check for those kerning table errors with the updated installed fonts? For me the errors are still reproduced on Firefox after updating those fonts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the issue is solved, please approve if verified on both FF and Chrome.
Yes.My tests:
Note that:
|
@rszwajko
Yes, that's what I did for disabling the cache - and errors are still reproduced for me.
The use case is: landing page -> SSO -> Dashboard The errors specified within the bug are dismissed now - so this is fixed - but those same errors without a source url appear for me on both brq-dev and my dev engine. On brq-dev:
dev engine:
|
@sgratch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. We tested different scenarios - sorry for incorrect steps! My scenario was precisely: landing page -> SSO -> home page (Virtual Machines). However errors in this scenario are expected.
Right, when landing on a non ui-extensions dialog, no such errors appear.
Therefore, this fix LGTM
/ost |
Changed fonts:
Reference-Url: googlefonts/opensans@ebedbda
Reference-Url: https://github.com/google/woff2
Reference-Url: https://packages.debian.org/unstable/sfnt2woff-zopfli
Bug-Url: https://bugzilla.redhat.com/2065068