build: use maven 3.6 --no-transfer-progress #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The github action CI build log tends to contain a large amount of log lines for the transfer progress of downloading dependencies. This can make a prohibitively large log file to be able to view it on the github action page. Use maven 3.6 and the option `--no-transfer-progress` to vastly reduce the log output to where we can actually scroll the the bottom of the output on the action's web page. Note: maven is a separate module on centos 8 stream. Copr chroot configs will need to be checked. Enabling at least maven 3.6 is requried.
sjd78
requested review from
didib,
sandrobonazzola,
mwperina,
ahadas,
bennyz,
emesika,
michalskrivanek,
oliel and
sgratch
as code owners
|
With the maven cache enabled, there isn't much of a change. But if the maven cache expires or |
mwperina
approved these changes
May 9, 2022
mwperina
added a commit
to mwperina/ovirt-engine
that referenced
this pull request
May 9, 2022
Passing --no-transfer-progress within EXTRA_BUILD_FLAGS introduced in oVirt#340 broke engine build in COPR, so we need to move that option into MAVEN_OPTS instead. Signed-off-by: Martin Perina <mperina@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github action CI build log tends to contain a large amount of
log lines for the transfer progress of downloading dependencies.
This can make a prohibitively large log file to be able to view
it on the github action page.
Use maven 3.6 and the option
--no-transfer-progressto vastly reducethe log output to where we can actually scroll the the bottom of the
output on the action's web page.
Note: maven is a separate module on centos 8 stream. Copr chroot
configs will need to be checked. Enabling at least maven 3.6 is
requried.