core: fix copying from MBS to image domain #349
Conversation
There is no need to reconstruct the sourceDisk as ManagedBlockDisk as it is already of this type if the source domain is a Managed Block Storage Domain, and it will fail later on as the conversion method createManagedBlockDiskFromDiskImage assigns the target's id to the constructed object which is incorrect, as this is the source disk. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
There was a problem hiding this comment.
can you please verify this with copy a template disk from/to a Managed Block Storage domain?
that was the original fix (https://bugzilla.redhat.com/2006745)
ack, works |
| @@ -167,7 +167,7 @@ protected void createVolumes() { | |||
| // Attach source to host (if source is Managed Block Storage) | |||
| // TODO: handle failures | |||
| if (sourceDomainType == StorageDomainType.ManagedBlockStorage) { | |||
| String sourcePath = attachVolume(createManagedBlockDiskFromDiskImage(sourceDisk)); | |||
There was a problem hiding this comment.
so how about renaming createManagedBlockDiskFromDiskImage to something like createDestinationManagedBlockDiskFromSourceDiskImage? a bit longer but would make it more clear that it's not an equivalent to casting..
There was a problem hiding this comment.
or maybe toDestinationManagedBlockDisk(DiskImage sourceImage)?
There was a problem hiding this comment.
I agree although I am not sure about the naming, maybe a better way would be to have createManagedBlockDiskFromDiskImage do the casting if object is already a ManagedBlockDisk but that could be confusing too
There is no need to reconstruct the
sourceDiskasManagedBlockDiskas it is already of this type if the source domain is a Managed Block Storage Domain, and it will fail later on as the conversion methodcreateManagedBlockDiskFromDiskImageassigns the target's id to the constructed object which is incorrect, as this is the source disk.