exclude /var/lib/ovirt-engine/ansible-runner from engine-backup #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangel101
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
/ost |
2 similar comments
|
/ost |
|
/ost |
mwperina
requested changes
May 10, 2022
didib
reviewed
May 10, 2022
packaging/bin/engine-backup.sh.in
Outdated
| @@ -173,7 +173,6 @@ BACKUP_PATHS="/etc/ovirt-engine | |||
| # Add /var/lib/ovirt-engine except a few | |||
| VAR_LIB_OVIRT_ENGINE_EXCLUSIONS="/var/lib/ovirt-engine/backups | |||
| /var/lib/ovirt-engine/jboss_runtime | |||
| /var/lib/ovirt-engine/ansible-runner-service.log | |||
There was a problem hiding this comment.
Why? See my previous reply. Thanks.
There was a problem hiding this comment.
I posted it the same time you posted your comment,
anyway I just added it back :)
packaging/bin/engine-backup.sh.in
Outdated
| @@ -173,7 +173,8 @@ BACKUP_PATHS="/etc/ovirt-engine | |||
| # Add /var/lib/ovirt-engine except a few | |||
| VAR_LIB_OVIRT_ENGINE_EXCLUSIONS="/var/lib/ovirt-engine/backups | |||
| /var/lib/ovirt-engine/jboss_runtime | |||
| /var/lib/ovirt-engine/ansible-runner-service.log" | |||
| /var/lib/ovirt-engine/ansible-runner-service.log | |||
| /var/lib/ovirt-engine/ansible-runner" | |||
There was a problem hiding this comment.
what about the /var/lib/ovirt-engine/.ansible dir?
There was a problem hiding this comment.
please exclude it as well
There was a problem hiding this comment.
ansible creates $HOME/.ansible automatically, we don't set there anything, so it should be safe to omit
dangel101
force-pushed
the
exclude_/var/lib/ovirt-engine/ansible-runner_from_backup
branch
from
5ce9426
to
f3e0b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.