webadmin: Fix creating of a new template #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
approved these changes
May 10, 2022
|
/ost |
|
Saw this error in my environment, this patch solves it. |
When creating a new template, the initTemplate() method is called after the list of base templates is loaded. However, if there are no templates other than the Blank template, the list is not loaded and the initTemplate() method is never called. As a result, the builders from VM to UnitVmModel are never called and the UnitVmModel is not initialized properly. The attempt to create a new template fails. This patch calls the initTemplate() method also for the cases when there are no base templates available and the Blank template is the only template present.
michalskrivanek
force-pushed
the
number_of_monitors
branch
from
82e2241
to
fdd2a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new template, the initTemplate() method is called after the list of base templates is loaded.
However, if there are no templates other than the Blank template, the list is not loaded and the initTemplate()
method is never called. As a result, the builders from VM to UnitVmModel are never called and the UnitVmModel
is not initialized properly. The attempt to create a new template fails.
This patch calls the initTemplate() method also for the cases when there are no base templates available and the Blank template is the only template present.