core: Use edited VM configuration when cloning #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration of a cloned VM may be edited before cloning. In this case it is passed in CloneVmParameters#vm and should be saved in editedVm variable and passed to UpdateVmCommand that is executed after cloning. The code that saves this configuration was incorrectly removed by change 6f143de. This patch restores this code with one difference: UpdateVmCommand is now executed by CoCo, so editedVm was moved from CloneVmCommand to parameters. Change-Id: Id77061ba6749351dcfbe832ad1c38288c6ada479 Bug-Url: https://bugzilla.redhat.com/2080758 Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
smelamud
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
ahadas
reviewed
May 12, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
Show resolved
Hide resolved
Change-Id: Ib61dd193a00e6130881de31b325cef8ba3b452ce Signed-off-by: Shmuel Melamud <smelamud@redhat.com>
ahadas
approved these changes
May 18, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration of a cloned VM may be edited before cloning. In this case
it is passed in CloneVmParameters#vm and should be saved in editedVm
variable and passed to UpdateVmCommand that is executed after cloning.
The code that saves this configuration was incorrectly removed by change
6f143de. This patch restores this code
with one difference: UpdateVmCommand is now executed by CoCo, so
editedVm was moved from CloneVmCommand to parameters.
Change-Id: Id77061ba6749351dcfbe832ad1c38288c6ada479
Bug-Url: https://bugzilla.redhat.com/2080758
Signed-off-by: Shmuel Melamud smelamud@redhat.com