Leverage the VM-lock in SetVmTicket #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
requested review from
bennyz,
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
/ost |
ahadas
removed request for
bennyz,
didib,
emesika,
mwperina,
michalskrivanek,
sgratch and
oliel
|
/ost |
Previously, we used optimisic locking to see if the user that tries to connect to the VM can do that or not. However, now that we lock the VM using VmManager's lock, we don't need that anymore - we can rather inspect VmDynamic in the command itself to discover it. Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
/ost |
liranr23
approved these changes
May 24, 2022
ljelinkova
reviewed
May 24, 2022
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used optimisic locking to see if the user that tries to
connect to the VM can do that or not. However, now that we lock the VM
using VmManager's lock, we don't need that anymore - we can rather
inspect VmDynamic in the command itself to discover it.
Signed-off-by: Arik Hadas ahadas@redhat.com