webadmin: trigger 'cancel' action on MoveOrCopyDiskModel #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljelinkova
approved these changes
May 13, 2022
In case the environment has a large amount of disks, and triggering the move/copy dialog opening and closing for a couple of times, the browser crashes due to a memory leak caused by a huge amount of property change listeners that remain although pressing the 'cancel' button. By triggering the 'cancel' operation including 'cleanup()', the browser doesn't crash as before. Bug-Url: https://bugzilla.redhat.com/2001574 Signed-off-by: Shani Leviim <sleviim@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
approved these changes
May 15, 2022
|
For creating 5000 disks on my env, I used the add_disks example from python-ovirt-engine-sdk4/examples: |
rszwajko
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the environment has a large amount of disks, and triggering the
move/copy dialog opening and closing for a couple of times, the browser
crashes due to a memory leak caused by a huge amount of property change
listeners that remain although pressing the 'cancel' button.
By triggering the 'cancel' operation including 'cleanup()', the browser
doesn't crash as before.
Bug-Url: https://bugzilla.redhat.com/2001574
Signed-off-by: Shani Leviim sleviim@redhat.com