-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tarfile.GNU_FORMAT in pack_ova.py when create OVA #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix export OVA-file with installed Python >= 3.8 on host
/ost |
liranr23
reviewed
May 15, 2022
packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack/files/pack_ova.py
Show resolved
Hide resolved
liranr23
approved these changes
May 15, 2022
ahadas
reviewed
May 15, 2022
packaging/ansible-runner-service-project/project/roles/ovirt-ova-pack/files/pack_ova.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
approved these changes
May 19, 2022
@antonios-f thanks for this contribution! |
Sure! :) |
tinez
added a commit
to tinez/ovirt-engine
that referenced
this pull request
Aug 18, 2022
We missed one place in oVirt#374. Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
tinez
added a commit
to tinez/ovirt-engine
that referenced
this pull request
Aug 18, 2022
We missed one place in oVirt#374. Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
mwperina
pushed a commit
that referenced
this pull request
Aug 19, 2022
We missed one place in #374. Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix export OVA-file with installed Python >= 3.8
When OVA exports by host with installed python >= 3.8, it can't be imported back, because in python >= 3.8 tarfile.PAX_FORMAT is used by default.