fix setting tuned profile #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
requested changes
May 18, 2022
| String tunedProfile = isGlusterServiceSupported ? hostCluster.getGlusterTunedProfile() : null; | ||
| boolean isVirtEnabled = hostCluster.supportsVirtService(); | ||
| String tunedProfile = isVirtEnabled && !isGlusterServiceSupported ? "virtual-host" | ||
| : isGlusterServiceSupported ? hostCluster.getGlusterTunedProfile() : null; |
There was a problem hiding this comment.
Does this fix the issue that gluster services are enabled for the cluster, but gluster tuned profile is set to NULL due to the UI bug? Wouldn't below condition be more clear?
String tunedProfile = "virtual-host";
if (hostCluster.supportsGlusterService() && StringUtils.isNotBlank(hostCluster.getGlusterTunedProfile())) {
// custom tuned profile is specified for gluster cluster
tunedProfile = hostCluster.getGlusterTunedProfile();
}
move profile setting from ansible role to engine
dangel101
force-pushed
the
B2073074_tuned_profile_on_gluster
branch
from
62b215a
to
22b0d32
Compare
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move profile setting from ansible role to engine