-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change conflict message to be more informative #383
Conversation
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
...badmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
4af5bb5
to
3c9953b
Compare
Hi, |
Sorry, maybe I'm missing something, but isn't this PR improves the message that will be displayed when initiating an image transfer while another operation is WIP (with exclusive lock on VM ID, like VM deletion), but not the opposite direction? Shouldn't the change be somewhere in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, other than that - lgtm
.../manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
Outdated
Show resolved
Hide resolved
the original bug is about a bit different issue - that one is unable to remove the vm and gets a message that the vm is locked while if you check the vm status it's not locked (because we're talking about an in-memory lock). so here we attach a better message when locking the vm as part of image transfer, so once you try to remove the vm you'll get a better message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change looks great but while on it, let's also address an issue we've noticed recently
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
Outdated
Show resolved
Hide resolved
1a44f58
to
5103216
Compare
when trying to remove VM while its disks are being transferred(uploaded or downloaded) you get this error message: 'Cannot remove VM: VM is locked. Please try again in a few minutes.' Now it will show more informative message: 'Cannot remove VM. Disk vm_Disk is being downloaded or uploaded.' Bug-Url: https://bugzilla.redhat.com/2066078 Signed-off-by: Artiom Divak adivak@redhat.com
…aredLocks Signed-off-by: Arik Hadas <ahadas@redhat.com>
/ost |
when trying to remove VM while its disks are being transferred(uploaded or downloaded) you get this error message:
'Cannot remove VM: VM is locked. Please try again in a few minutes.'
Now it will show more informative message: 'Cannot remove VM. Disk vm_Disk is being transferred.'
Bug-Url: https://bugzilla.redhat.com/2066078
Signed-off-by: Artiom Divak adivak@redhat.com