Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: allow setting the 'backup' flag while creating a VM from a temp… #398

Merged
merged 1 commit into from
May 31, 2022
Merged

core: allow setting the 'backup' flag while creating a VM from a temp… #398

merged 1 commit into from
May 31, 2022

Conversation

sleviim
Copy link
Member

@sleviim sleviim commented May 26, 2022 •
edited

core: set the 'backup' flag while creating a VM from a template

When creating a VM from a template with disks attached,
and trying to set the backup_mode during the creation,
the 'backup' flag seems to be ignored.
Therefore, setting the backup_mode to incremental is possible only after the creation was completed.

Bug-Url:https://bugzilla.redhat.com/2046689
Signed-off-by: Shani Leviim sleviim@redhat.com

@sleviim sleviim requested review from barpavel and mkemel May 26, 2022 15:20
@sleviim
Copy link
Member Author

sleviim commented May 26, 2022

Verification:
POST http://localhost:8080/ovirt-engine/api/vms/

<vm>
    <name>myvm2</name>
    <description>My VM</description>
    <cluster>
        <name>Default</name>
    </cluster>
    <template>
        <name>temp-rhel-7.9</name>
    </template>
    <disk_attachments>
        <disk_attachment>
            <disk id="90717efe-2a12-4b19-a91a-b8241db7c3ea">
                <backup>incremental</backup>
            </disk>
        </disk_attachment>
    </disk_attachments>
</vm>

barpavel
barpavel approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@barpavel barpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small non-mandatory suggestions.

...es/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java Show resolved Hide resolved
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java Show resolved Hide resolved
@bennyz
Copy link
Member

bennyz commented May 29, 2022

/ost

@sleviim
Copy link
Member Author

sleviim commented May 29, 2022

/ost

2 similar comments
@bennyz
Copy link
Member

bennyz commented May 30, 2022

/ost

@bennyz
Copy link
Member

bennyz commented May 30, 2022

/ost

@bennyz bennyz self-requested a review May 30, 2022 14:23
@sleviim
core: allow setting the 'backup' flag while creating a VM from a temp…
4039cc4 
…late

When creating a VM from a template with disks attached,
and trying to set the backup_mode during the creation,
the 'backup' flag seems to be ignored.
Setting the backup_mode to incremental is possible only after the creation was completed.

Bug-Url:https://bugzilla.redhat.com/2046689
Signed-off-by: Shani Leviim <sleviim@redhat.com>
@sleviim
Copy link
Member Author

sleviim commented May 30, 2022

/ost

@bennyz bennyz merged commit f029aad into oVirt:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barpavel barpavel barpavel approved these changes

@bennyz bennyz bennyz approved these changes

@ahadas ahadas Awaiting requested review from ahadas ahadas is a code owner

@emesika emesika Awaiting requested review from emesika emesika is a code owner

@mwperina mwperina Awaiting requested review from mwperina mwperina is a code owner

@michalskrivanek michalskrivanek Awaiting requested review from michalskrivanek michalskrivanek is a code owner

@oliel oliel Awaiting requested review from oliel

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@didib didib Awaiting requested review from didib didib is a code owner

@mkemel mkemel Awaiting requested review from mkemel

Assignees
No one assigned
Labels
storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sleviim @bennyz @barpavel