-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: allow setting the 'backup' flag while creating a VM from a temp… #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verification:
|
barpavel
approved these changes
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small non-mandatory suggestions.
...es/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
Show resolved
Hide resolved
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Show resolved
Hide resolved
bennyz
approved these changes
May 29, 2022
/ost |
/ost |
2 similar comments
/ost |
/ost |
…late When creating a VM from a template with disks attached, and trying to set the backup_mode during the creation, the 'backup' flag seems to be ignored. Setting the backup_mode to incremental is possible only after the creation was completed. Bug-Url:https://bugzilla.redhat.com/2046689 Signed-off-by: Shani Leviim <sleviim@redhat.com>
/ost |
bennyz
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: set the 'backup' flag while creating a VM from a template
When creating a VM from a template with disks attached,
and trying to set the backup_mode during the creation,
the 'backup' flag seems to be ignored.
Therefore, setting the backup_mode to incremental is possible only after the creation was completed.
Bug-Url:https://bugzilla.redhat.com/2046689
Signed-off-by: Shani Leviim sleviim@redhat.com