core: do not remove snapshot from DB if related images were not removed #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
changed the title
bennyz
force-pushed
the
fix-snapshot-rollback
branch
from
c579c58
to
904c14c
Compare
liranr23
reviewed
May 31, 2022
...odules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java
Show resolved
Hide resolved
bennyz
force-pushed
the
fix-snapshot-rollback
branch
from
904c14c
to
4c60bfa
Compare
|
/ost |
bennyz
force-pushed
the
fix-snapshot-rollback
branch
from
4c60bfa
to
d9150ac
Compare
Move isSnapshotUsed to ImagesHandler, to allow its reuse in other classes. Bug-Url: https://bugzilla.redhat.com/2081294 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
fix-snapshot-rollback
branch
from
d9150ac
to
aa08e18
Compare
bennyz
requested review from
emesika,
mwperina,
michalskrivanek,
oliel,
sgratch and
didib
as code owners
|
/ost |
ahadas
reviewed
Jun 13, 2022
...er/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
Show resolved
Hide resolved
...odules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java
Outdated
Show resolved
Hide resolved
If we ended up not removing the new active volume from the storage because they may be in-use, do not remove the snapshot from the database as it may create a discrepancy between the engine DB and the storage, leading to other issues. Bug-Url: https://bugzilla.redhat.com/2081294 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
When running endWithFailure in CreateSnapshotForVmCommand, setSucceeded will be set to false if there was a failure in one of the tasks, but this does not mean the cleanup failed, and since it is not retried anyway there is no reason not to always set it to true. Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
fix-snapshot-rollback
branch
from
aa08e18
to
344ad78
Compare
liranr23
reviewed
Jun 13, 2022
...odules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java
Show resolved
Hide resolved
liranr23
approved these changes
Jun 13, 2022
ahadas
approved these changes
Jun 14, 2022
|
/ost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we ended up not removing the new active volume from the storage
because they may be in-use, do not remove the snapshot from the database
as it may create a discrepancy between the engine DB and the storage,
leading to other issues.
Bug-Url: https://bugzilla.redhat.com/2081294
Signed-off-by: Benny Zlotnik bzlotnik@redhat.com